Delete the WordPressAuthenticator library - #25646
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32635 | |
| Version | PR #25646 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5965679 | |
| Installation URL | 5g2osepel3jto |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32635 | |
| Version | PR #25646 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5965679 | |
| Installation URL | 7f3i8609168v8 |
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 00:15
56b3c8a to
93f49c2
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase5
branch
from
June 15, 2026 00:15
3c37b48 to
47fc4a6
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 00:50
93f49c2 to
2dd2128
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase5
branch
from
June 15, 2026 00:50
47fc4a6 to
ab4681c
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 01:23
2dd2128 to
c567244
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase5
branch
from
June 15, 2026 01:23
ab4681c to
7610c8f
Compare
jkmassel
approved these changes
Jun 15, 2026
crazytonyli
force-pushed
the
task/remove-authenticator-phase4
branch
from
June 15, 2026 03:21
c567244 to
ad92a12
Compare
crazytonyli
force-pushed
the
task/remove-authenticator-phase5
branch
from
June 15, 2026 03:21
7610c8f to
aa8b8ed
Compare
Removes the library sources and tests, the navigator groups, the scheme and test plan references, the Swift package manifest entries, and the localization and lint configuration entries. The library's two features are fully replaced by the web-based WordPress.com sign-in and the application password sign-in flow.
crazytonyli
force-pushed
the
task/remove-authenticator-phase5
branch
from
June 15, 2026 03:56
aa8b8ed to
5965679
Compare
crazytonyli
marked this pull request as ready for review
June 15, 2026 04:00
crazytonyli
enabled auto-merge
June 15, 2026 04:00
pull Bot
pushed a commit
to kliu/WordPress-iOS
that referenced
this pull request
Jul 22, 2026
…press-mobile#25803) * Remove dead Google login credentials Removed with WordPressAuthenticator, via f8ad8c4 - wordpress-mobile#25646 * Remove dead GoogleSignIn URL scheme entries These were the OAuth callback schemes — reversed Google client IDs — for the Google sign-in flow that lived in `WordPressAuthenticator`, deleted in wordpress-mobile#25646. Nothing handles the scheme anymore. The schemes were hardcoded here rather than injected from `googleLoginSchemeId`, so removing that secret in the preceding commit left them untouched and equally dead. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Move Sentry DSN definition from secrets to `Info.plist` That value does not need to be secret. See https://docs.sentry.io/concepts/key-terms/dsn-explainer/#dsn-utilization * Update DocsBot documentation links The `/docs/` path the widget comment pointed at is stale; the page now lives under `/documentation/developer/`. The same link sits on `docsBotId` because it establishes what the value is: the widget `id` is embed code, documented for placement in a site's public HTML. That makes it a candidate to leave `BuildSecrets` the way the Sentry DSN did. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Move Docs Bot ID from secrets to Jetpack's `Info.plist` * Read one secrets file for all app targets The per-app branching existed because the secrets files held app-specific values. Those have since moved to each app's `Info.plist`, read via `BuildSettings`, leaving only values the three apps share. `WordPress-Secrets-Internal.swift` and `-Alpha.swift` leave the input list too: the script stopped reading them well before this change. The shebang moves to `#!/usr/bin/env bash` with a separate `set -euo pipefail`. `#!/bin/bash -euo pipefail` passed multiple parameters, which most systems do not support. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Fix stale script path in credentials filelist The entry pointed at `ApplyConfiguration.sh`, renamed in e78ed88 and never updated here, so the self-dependency its comment describes was not wired: Xcode had no edge from the build phase to the script driving it. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Store the Sentry DSN without its scheme `INFOPLIST_PREPROCESS` is on for WordPress and Jetpack, so the plist goes through the C preprocessor, where `//` opens a comment. The `https://` in the DSN swallowed the rest of the line including `</string>`, leaving XML that `ProcessInfoPlistFile` could not parse, and every app build failed. Reader does not preprocess its plist, but the value is read through one code path, so all three stay consistent. This mirrors `WPProductBlogURL`, which is stored scheme-less for the same reason. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Slim down AI-generated comment * Name the Sentry DSN key for its missing scheme The constraint only shows up in `BuildSettings+Live.swift`, which someone editing the plist never opens. `WPSentryNoSchemeDSN` states it where a full DSN would otherwise get pasted, and unlike an XML comment it survives Xcode's plist editor. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> * Remove now-unused app-specific secrets * Drop the app prefix from the secrets file name Every target reads this file now, so naming it after one of them misleads. It also matches the source name in the secrets repo, `iOS/WPiOS/Secrets.swift`. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Code Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25645