Feature/7675 google button touch states - #8015
Closed
aerych wants to merge 4 commits into
Closed
Conversation
Contributor
|
@aerych moving the code into a
As you can see, |
Contributor
Author
|
🤦♂️ Ugh. I had it in my head that we wanted it to truncate for some reason. Yeah this is gonna need a rethink. |
Contributor
Author
|
Closing this. The truncation is necessary and I totally spaced on that. I'll revisit in a new pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7675
Tweaks the google button so it shows a tapped state. I opted to use light blue for the tapped state for consistency with hovers in Calypso and the behavior of link-style buttons in the iOS reader.
Normal:
Pressed:
To test:
View the LoginEmailViewController and tap the button. Confirm that it changes state.
Needs review: @nheagy for code & @folletto for style