Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Match "Need more help" language - #631

Merged
twstokes merged 2 commits into
trunkfrom
bug/need-more-help
Jan 18, 2022
Merged

Match "Need more help" language#631
twstokes merged 2 commits into
trunkfrom
bug/need-more-help

Conversation

@twstokes

@twstokes twstokes commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

This PR updates the error message "Unable to read the WordPress site at that URL. Tap 'Need Help?' to view the FAQ." to match the button label, which is "Need more help?"

Before After
Mode 2 and 4 Match Text

Testing:

On a self-hosted site:

  1. Install XML-RPC Tweak from this PR
  2. Configure the plugin to run in Mode 4
  3. Attempt to log into the self-hosted site

@twstokes twstokes changed the title Bug/need more help Match "Need more help" language Jan 13, 2022
@twstokes twstokes added the bug Something isn't working label Jan 13, 2022
@twstokes
twstokes marked this pull request as ready for review January 13, 2022 06:04
@twstokes
twstokes requested a review from guarani January 18, 2022 17:51
@twstokes

Copy link
Copy Markdown
Contributor Author

@guarani would you mind giving this PR a review since you assisted with the previous one? 🙇

@guarani guarani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd noticed that the instructions didn't match the button title yesterday but it was unrelated to your PR and I didn't follow up on it myself, so thank you so much for tackling this!

@twstokes

Copy link
Copy Markdown
Contributor Author

Thanks again for reviewing @guarani!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants