This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Improve error description - #632
Merged
Merged
Conversation
twstokes
force-pushed
the
feature/xml-rpc-errors
branch
from
January 13, 2022 04:30
6cb4964 to
86290bb
Compare
Merged
4 tasks
twstokes
changed the title
twstokes
changed the title
twstokes
marked this pull request as ready for review
January 13, 2022 06:03
guarani
self-requested a review
January 13, 2022 19:18
guarani
approved these changes
Jan 14, 2022
guarani
left a comment
guarani
left a comment
There was a problem hiding this comment.
Tested in wordpress-mobile/WordPress-iOS#17724 (review) and code changes look good!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR:
Note: There's a follow-up PR to make the message match the button label.
Testing: