This repository was archived by the owner on Jan 10, 2025. It is now read-only.
[TouchRunner] do not use FinallyDelegate in Runner, because it requires remoting API to be available - #49
Merged
Conversation
Contributor
Author
spouliot
suggested changes
Feb 19, 2018
spouliot
left a comment
spouliot
left a comment
Contributor
There was a problem hiding this comment.
it can be simplified to remove FinallyDelegate
| TestExecutionContext current = TestExecutionContext.CurrentContext; | ||
| current.WorkDirectory = Environment.CurrentDirectory; | ||
| current.Listener = this; | ||
| #if __IOS__ || __WATCHOS__ || __TVOS__ |
Contributor
There was a problem hiding this comment.
those are the only 3 platforms that TouchUnit supports :)
…es remoting API to be available
lewurm
force-pushed
the
touchrunner-finallydelegate-cond
branch
from
February 19, 2018 15:03
9f69aa2 to
ae88e16
Compare
spouliot
approved these changes
Feb 20, 2018
lewurm
added a commit
to lewurm/Touch.Unit
that referenced
this pull request
Feb 26, 2018
…t requires remoting API to be available (xamarin#49)" This reverts commit 4ac4e32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on mono/NUnitLite#7