Fix build error on mingw32#570
Closed
cyb70289 wants to merge 1 commit into
Closed
Conversation
Mingw32 build failed with missing _mm_cvtsi128_si64 definition, which is only available on 64bit platform.
cyb70289
commented
Sep 28, 2021
| __m256i tmp2 = _mm256_add_epi64(self, tmp1); | ||
| __m128i tmp3 = _mm256_extracti128_si256(tmp2, 1); | ||
| __m128i res = _mm_add_epi64(_mm256_castsi256_si128(tmp2), tmp3); | ||
| #if defined(__x86_64__) |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Then correct me if I'm wrong : it's more an issue of 32 bits versus 64bits, right? If that's indeed the case, it means we should add a bot that capture that scenario before we merge that PR. I'll do that
Contributor
Author
There was a problem hiding this comment.
Yes, it's an issue only on 32 bits.
Contributor
Author
There was a problem hiding this comment.
Feel free to pick this change if it's useful.
Contributor
|
Obsoleted by #571 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mingw32 build failed with missing _mm_cvtsi128_si64 definition, which
is only available on 64bit platform.