Skip to content

ARROW-13944: [C++] Bump xsimd to latest version#11142

Closed
cyb70289 wants to merge 1 commit into
apache:masterfrom
cyb70289:13944-bump-xsimd
Closed

ARROW-13944: [C++] Bump xsimd to latest version#11142
cyb70289 wants to merge 1 commit into
apache:masterfrom
cyb70289:13944-bump-xsimd

Conversation

@cyb70289
Copy link
Copy Markdown
Contributor

@cyb70289 cyb70289 commented Sep 13, 2021

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 13, 2021

https://issues.apache.org/jira/browse/ARROW-13944

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 13, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@cyb70289 cyb70289 marked this pull request as draft September 13, 2021 07:44
@cyb70289
Copy link
Copy Markdown
Contributor Author

cyb70289 commented Sep 14, 2021 •
edited
Loading

Reported xsimd msvc build failure xtensor-stack/xsimd#561 [FIXED]

@cyb70289
Copy link
Copy Markdown
Contributor Author

cyb70289 commented Sep 28, 2021 •
edited
Loading

Hmm..., there are more issues need be fixed in xsimd.
xtensor-stack/xsimd#570 [FIXED]
xtensor-stack/xsimd#572 [FIXED]
xtensor-stack/xsimd#573 [FIXED]

cyb70289
cyb70289 commented Sep 29, 2021
View reviewed changes
Comment thread cpp/cmake_modules/SetupCxxFlags.cmake Outdated
@cyb70289
Copy link
Copy Markdown
Contributor Author

cyb70289 commented Sep 29, 2021

@ursabot please benchmark

@ursabot
Copy link
Copy Markdown

ursabot commented Sep 29, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = b60bbb3 and contender = 5bba8a5688686b6d1e478941396c5ec621449fa6. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.01% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.28%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@cyb70289
Copy link
Copy Markdown
Contributor Author

cyb70289 commented Sep 29, 2021 •
edited
Loading

Looks there's big improvement of utf8 validation simd code
https://conbench.ursa.dev/compare/benchmarks/646cee3f36734033ad50fbf072b5a125...a2b135bc912945fcaedd72ae15edc8e5/

Don't see any difference on my local test with clang-10, xeon gold 5218.

@cyb70289 cyb70289 marked this pull request as ready for review September 29, 2021 15:08
@cyb70289 cyb70289 requested a review from pitrou September 29, 2021 15:10
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Oct 11, 2021

@github-actions crossbow submit -g cpp

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 11, 2021

Revision: 55722be

Submitted crossbow builds: ursacomputing/crossbow @ actions-912

Task Status
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-11-cpp Github Actions
test-fedora-33-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions

pitrou
pitrou approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @cyb70289.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Oct 11, 2021

CI failures on Crossbow look unrelated.

@pitrou pitrou closed this in 2330770 Oct 11, 2021
@ursabot
Copy link
Copy Markdown

ursabot commented Oct 11, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 93b09fa and contender = 2330770. 2330770 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@cyb70289 cyb70289 deleted the 13944-bump-xsimd branch October 12, 2021 00:11
@asfimport asfimport mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyb70289 @ursabot @pitrou