Skip to content

Fix msvc build warnings #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 1 commit into from
Sep 28, 2021
Merged

Fix msvc build warnings #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/xsimd/config/xsimd_config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,34 +211,42 @@
#ifdef _MSC_VER

#if XSIMD_WITH_AVX512
#undef XSIMD_WITH_AVX2
#define XSIMD_WITH_AVX2 1
#endif

#if XSIMD_WITH_AVX2
#undef XSIMD_WITH_AVX
#define XSIMD_WITH_AVX 1
#endif

#if XSIMD_WITH_AVX
#undef XSIMD_WITH_SSE4_2
#define XSIMD_WITH_SSE4_2 1
#endif

#if !defined(__clang__) && (defined(_M_X64) || (defined(_M_IX86_FP) && _M_IX86_FP >= 2))
#undef XSIMD_WITH_SSE4_2
Copy link
Copy Markdown
Contributor Author

@cyb70289 cyb70289 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macro redefinition warning:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/40931652/job/mntqw7s7volnfq8y#L634

#define XSIMD_WITH_SSE4_2 1
#endif

#if XSIMD_WITH_SSE4_2
#undef XSIMD_WITH_SSE4_1
#define XSIMD_WITH_SSE4_1 1
#endif

#if XSIMD_WITH_SSE4_1
#undef XSIMD_WITH_SSSE3
#define XSIMD_WITH_SSSE3 1
#endif

#if XSIMD_WITH_SSSE3
#undef XSIMD_WITH_SSE3
#define XSIMD_WITH_SSE3 1
#endif

#if XSIMD_WITH_SSE3
#undef XSIMD_WITH_SSE2
#define XSIMD_WITH_SSE2 1
#endif

Expand Down
4 changes: 2 additions & 2 deletions test/test_select.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class select_test : public testing::Test
detail::store_batch(out, res, i);
}
size_t diff = detail::get_nb_diff(res, expected);
EXPECT_EQ(diff, 0) << print_function_name("pow");
EXPECT_EQ(diff, 0) << print_function_name("select_dynamic");
Copy link
Copy Markdown
Contributor Author

@cyb70289 cyb70289 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happen to see this typo

}
struct pattern
{
Expand All @@ -83,7 +83,7 @@ class select_test : public testing::Test
detail::store_batch(out, res, i);
}
size_t diff = detail::get_nb_diff(res, expected);
EXPECT_EQ(diff, 0) << print_function_name("pow");
EXPECT_EQ(diff, 0) << print_function_name("select_static");
}
};

Expand Down