Fix msvc build warnings#572
Merged
Merged
Conversation
cyb70289
commented
Sep 28, 2021
| #endif | ||
|
|
||
| #if !defined(__clang__) && (defined(_M_X64) || (defined(_M_IX86_FP) && _M_IX86_FP >= 2)) | ||
| #undef XSIMD_WITH_SSE4_2 |
Contributor
Author
There was a problem hiding this comment.
macro redefinition warning:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/40931652/job/mntqw7s7volnfq8y#L634
cyb70289
commented
Sep 28, 2021
| } | ||
| size_t diff = detail::get_nb_diff(res, expected); | ||
| EXPECT_EQ(diff, 0) << print_function_name("pow"); | ||
| EXPECT_EQ(diff, 0) << print_function_name("select_dynamic"); |
Contributor
Author
There was a problem hiding this comment.
happen to see this typo
cyb70289
commented
Sep 28, 2021
There are some msvc build warnings in current xsimd code. It may block adoption of xsimd by some projects (e.g., apache arrow) if they treat compiler warnings as errors. As xsimd is header only, there's no way to build xsimd separately to suppress the warnings. Fixing build warnings is also good for project quality.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some msvc build warnings in current xsimd code. It may block
adoption of xsimd by some projects (e.g., apache arrow) if they treat
compiler warnings as errors. As xsimd is header only, it's not easy to
build xsimd separately to ignore the warnings.