You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for the late reply. Even if I would like to avoid macro as much as possible, it looks like we don't have the choice here, I don't have a better solution to offer.
I also don't like macros.
For C++14, a better approach may be defining only one macro to wrap all intrinsics. #define F(f) [](auto... args){ return f(args...); }
Then we have to change make_tuple(vorrq_u8, vorrq_s8, ...) to make_tuple(F(vorrq_u8), F(vorrq_s8), ...).
Haven't tested, looks it can work.
For C++11, we need to infer function parameter type, should be doable.
Looks very good to me, I like how the code is homogeneous with existing intrinsics and how the same pattern is applied everywhere, it makes the code easy to read and understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #573