Fix: argType detail popover overflows viewport when content is tall#16
Draft
Fix: argType detail popover overflows viewport when content is tall#16
Conversation
…ort when content is tall Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
…ort + add E2E test + update skill docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix argType detail popover overflow issue
Fix: argType detail popover overflows viewport when content is tall
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
table.type.detailcontains many lines, thePopoverProviderpopover extends beyond the viewport with no scrollbar — react-aria correctly computes and setsmax-heightviauseOverlayPosition, butoverflowwas unset (defaulting tovisible), so content escaped the element boundary.Before
After
Changes
PopoverProvider.tsx— addoverflow: 'auto'toPopoverUpstreaminline style so constrained height scrolls rather than overflowsArgRow.stories.tsx— addLongDetailPopoverstory with 55-item icon name list intable.type.detail, mirroring the original reproductionmanager.spec.ts— E2E test assertingoverflowY: autoandscrollHeight > clientHeighton the opened dialogWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphqlWhat I did
The
PopoverProvidercomponent wraps react-aria'sPopoverwhich correctly constrains the popover height viamax-height, but withoutoverflow: autothe content would visually overflow outside the element instead of scro ybook/node_modulbranch ybook/node_modul--show-current -786eec917292---%ce---786eec9172security -c (git diff --name-only --no-relatOUTPUT rd /usr/bin/git standard) | git /bin/sh ybook/node_modul-c 1/x64/bin/bash git` (http block)What I did
The
PopoverProvidercomponent wraps react-aria'sPopoverwhich correctly constrains the popover height viamax-height, but withoutoverflow: autothe content would visually overflow outside the element instead of scro ct ## %ae ## %anbash -n /usr/local/bin/g--noprofile /bin/sh -c email git /bin/sh standard) | git git HEAD hrome-linux/head--name-only /bin/sh` (http block)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.