docs: ADR 由来のドキュメント drift を修正（SEC_review 観点5・deployment の secret 一覧）

[yusuke0610]

• SEC_review スキルの観点5「LLM プロンプトのサニタイズ」を更新。
  ADR-0008（LLM 廃止）当時の記述のままだったが、ADR-0010 で DevForge Agent
  として LLM を再導入済みのため、現行アーキテクチャ（context_builder /
  静的プロンプト / 構造化出力）に即した確認項目に置き換え
• docs/deployment.md の常時注入 secret 一覧から anthropic-api-key を削除。
  ADR-0015 で Anthropic / Gemini は Vertex AI（ADC）経由へ移行済みで、
  infra 実装（cloud_run/main.tf）では注入・コンテナとも削除済みだった

Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015qpm5pb2utquc7NsTtru5J

Summary by CodeRabbit

• New Features

  • Added an official ADR index and a new design-principles guide for easier navigation of architecture decisions.
  • Added automated checks to keep ADR files and the index in sync during validation and CI.

• Documentation

  • Updated contribution, PR, README, and deployment guidance to reflect the new ADR workflow and required secret settings.

• Bug Fixes

  • Corrected an ADR numbering issue in one document and clarified which API keys are needed for deployment.

[coderabbitai]

Warning

Review limit reached

@yusuke0610, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 73976187-7145-40a5-9e47-6efe0c445bc3

📥 Commits

Reviewing files that changed from the base of the PR and between 684f6be and 05df6a2.

📒 Files selected for processing (1)

• scripts/lint-adr-index.sh

📝 Walkthrough

Walkthrough

This PR establishes docs/adr/README.md as the authoritative ADR index, adds a scripts/lint-adr-index.sh validation script wired into Makefile and CI, introduces docs/design-principles.md (P1–P7), and updates CLAUDE.md, CONTRIBUTING.md, PR template, ADR template, deployment docs, and the SEC_review skill accordingly.

Changes

ADR Index Governance and Validation

Layer / File(s)	Summary
ADR index document docs/adr/README.md	Adds accepted decisions table, full ADR listing table, and theme-based Mermaid decision-relationship diagrams.
Drift validation script scripts/lint-adr-index.sh	Validates filename/heading consistency, index membership, link targets, and Accepted status consistency between ADR files and the index.
CI and Makefile wiring Makefile, .github/workflows/test.yml	Adds lint-adr-index make target wired into lint/.PHONY/help, and a corresponding CI lint step.
Design principles document docs/design-principles.md	Adds P1–P7 principles with rationale, exceptions, and an ADR-to-principle mapping matrix.
Process and template doc updates .claude/CLAUDE.md, .github/PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md, docs/adr/0000-template.md, docs/adr/0011-frontend-textlint-proofread.md, README.md	Updates guidance to reference the ADR index and design-principles doc, enforces index updates on ADR changes, and fixes an ADR heading number.
Deployment and security review doc updates docs/deployment.md, .claude/skills/SEC_review/SKILL.md	Updates Secret Manager secret list for Stripe/Vertex AI changes and revises the LLM prompt sanitization review checklist.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

• yusuke0610/devforge#293: Both PRs modify .claude/skills/SEC_review/SKILL.md security review content.

Suggested labels: ci

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the PR’s main goal of fixing ADR-driven documentation drift, including the SEC_review update and deployment secret list change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/adr-product-alignment-qktb1g

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

scripts/lint-adr-index.sh (1)

94-126: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider also validating title consistency between the two tables.

Status/Accepted-set drift is checked between "全 ADR 一覧" and "現在有効な決定", but title text isn't cross-checked between the two tables. If a title is updated in one table but not the other, the lint won't catch it.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/lint-adr-index.sh` around lines 94 - 126, The current lint in
lint-adr-index.sh only compares ADR status and the Accepted set, so title text
can drift between the “全 ADR 一覧” and “現在有効な決定” tables without detection. Extend
the existing table cross-check logic near the
accepted_file_nums/index_accepted_nums handling to also extract each ADR title
from both tables and compare them for matching ADR numbers, emitting an error
when the same ADR has different titles. Keep the check aligned with the existing
parsing style and use the same ADR identifiers (for example ADR-$num) so
mismatches are reported consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@scripts/lint-adr-index.sh`:
- Around line 94-126: The current lint in lint-adr-index.sh only compares ADR
status and the Accepted set, so title text can drift between the “全 ADR 一覧” and
“現在有効な決定” tables without detection. Extend the existing table cross-check logic
near the accepted_file_nums/index_accepted_nums handling to also extract each
ADR title from both tables and compare them for matching ADR numbers, emitting
an error when the same ADR has different titles. Keep the check aligned with the
existing parsing style and use the same ADR identifiers (for example ADR-$num)
so mismatches are reported consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aff473d3-dcc4-4495-bf17-3e2eade34d9a

📥 Commits

Reviewing files that changed from the base of the PR and between 61aca04 and 684f6be.

📒 Files selected for processing (13)

• .claude/CLAUDE.md
• .claude/skills/SEC_review/SKILL.md
• .github/PULL_REQUEST_TEMPLATE.md
• .github/workflows/test.yml
• CONTRIBUTING.md
• Makefile
• README.md
• docs/adr/0000-template.md
• docs/adr/0011-frontend-textlint-proofread.md
• docs/adr/README.md
• docs/deployment.md
• docs/design-principles.md
• scripts/lint-adr-index.sh