Skip to content

docs(adr): ブログ連携機能の撤去 ADR を起票(ADR-0022 / #518)#529

Merged
yusuke0610 merged 2 commits into
mainfrom
docs/adr-blog-removal
Jul 21, 2026
Merged

docs(adr): ブログ連携機能の撤去 ADR を起票(ADR-0022 / #518)#529
yusuke0610 merged 2 commits into
mainfrom
docs/adr-blog-removal

Conversation

@yusuke0610

@yusuke0610 yusuke0610 commented Jul 21, 2026

Copy link
Copy Markdown
Owner

概要

機能整理ロードマップ #517 のサブ issue #518。ブログ連携(Zenn / note 同期・記事一覧・投稿スコアリング)を撤去する方針を ADR-0022 として起票する。本 PR は ADR のみ(撤去実装は次の #519)。

背景

  • 経歴書へ還流せず、一覧 + スコア表示止まりの独立した島になっている
  • 投稿頻度スコアはブランクのあるユーザに逆効果になり得る
  • note は RSS スクレイピング依存で外部仕様変更に弱い
  • 還流のないまま lint / test / codegen / 依存追従の保守コストが継続

内容

  • docs/adr/0022-remove-blog-integration.md を新規作成(Accepted)
    • ADR-0008(LLM 全撤去)の流儀に倣い、次の実装 PR [ブログ撤去 2/2] 撤去実装: backend / web / DB / codegen #519 のチェックリスト粒度で撤去対象を全量列挙(DB テーブル 3 つ / backend / web / codegen 生成物)
    • Agent への波及を既知トレードオフとして明記(context_builder._build_blog_context がブログスコアを Agent コンテキストへ注入 → 撤去で職務要約・自己PR 提案の参照データからスコアが消える。ADR-0010 の DB 非更新原則・契約は不変)
  • docs/adr/README.md 索引を同一 PR で更新(現在有効な決定 + 全 ADR 一覧の両表)

受け入れ条件

CI

make ci ローカル green。差分は docs のみ。

Closes #518

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Documented the decision to remove blog integrations, including synchronization, article listings, and post scoring.
    • Recorded the expected impact on generated career summaries and self-introduction content.
    • Added the decision to the architecture decision records index.

経歴書へ還流せず投稿頻度スコアが逆効果になり得るブログ連携を全量撤去する
方針を ADR として記録する。ADR-0008(LLM 全撤去)の流儀に倣い、次の実装
PR(#519)のチェックリストに使える粒度で撤去対象を全量列挙した。

- DB テーブル 3 つ・backend(routers/services/repositories/models/schemas)
  ・web(page/components/api/hooks/routes/sidebar/messages)・codegen 生成物を列挙
- Agent への波及(context_builder の _build_blog_context がブログスコアを
  Agent コンテキストへ注入)を既知トレードオフとして明記
- docs/adr/README.md 索引を同一 PR で更新(lint-adr-index green)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yusuke0610, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d6cbf02d-1e0c-4e68-9e0e-3af85c50c367

📥 Commits

Reviewing files that changed from the base of the PR and between 51c2edf and 76f56fc.

📒 Files selected for processing (1)
  • docs/adr/0022-remove-blog-integration.md
📝 Walkthrough

Walkthrough

ブログ連携機能の撤去方針をADR-0022として文書化し、撤去対象、Agentコンテキストへの影響、将来の移行条件を記載しました。ADR索引のAccepted一覧と全一覧にも追加しています。

Changes

ブログ連携撤去の意思決定

Layer / File(s) Summary
撤去ADRと索引の更新
docs/adr/0022-remove-blog-integration.md, docs/adr/README.md
ブログ連携のDB・backend・web・codegen・テスト対象、Agentコンテキストへの影響、代替案、将来の移行条件をADR-0022に記録し、ADR索引の2箇所へ追加しました。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • #519: ADR-0022で承認されたブログ連携撤去の対象と一致します。
  • #517: ブログ連携撤去の背景とAgentコンテキストへの影響を共有しています。

Possibly related PRs

  • yusuke0610/devforge#462: context_builder.py におけるAgentコンテキスト構築と、関連するADR・セキュリティレビュー方針を扱っています。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the ADR is for removing blog integration and matches the changeset.
Linked Issues check ✅ Passed The ADR documents the requested removal scope, agent impact, and README index update, matching issue #518.
Out of Scope Changes check ✅ Passed The PR only adds the ADR and updates the ADR index, both directly in scope for the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-blog-removal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/adr/0022-remove-blog-integration.md`:
- Line 24: Expand the removal inventory in ADR-0022 to explicitly list backend
task-handler paths and all related env, ErrorCode, frontend constant, and
documentation files or symbols. Match the detailed checklist style of ADR-0008
so PR `#519` can verify scheduled jobs, configuration, and stale assets are fully
removed.
- Line 72: Update the ADR’s removal prerequisites to require verifying that no
internal or external clients consume the blog APIs before proceeding with `#519`,
and document how that verification will be performed. If any consumer is found,
replace the removal-only plan with a deprecation and migration plan.
- Around line 57-60: ADR-0022 must explicitly address the Agent contract
migration caused by removing blog_context. Update the ADR to state that
agent_career_summary.md, agent_self_pr.md, and test_agent.py must be updated
together with services/agent/context_builder.py, or retain blog_context until
those consumers are migrated; preserve prompt and test consistency throughout
the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e427c706-589f-4395-abc0-ea933e9b930c

📥 Commits

Reviewing files that changed from the base of the PR and between aa78d18 and 51c2edf.

📒 Files selected for processing (2)
  • docs/adr/0022-remove-blog-integration.md
  • docs/adr/README.md

Comment thread docs/adr/0022-remove-blog-integration.md
Comment thread docs/adr/0022-remove-blog-integration.md Outdated
Comment thread docs/adr/0022-remove-blog-integration.md
PR #529 の CodeRabbit レビュー 3 件に対応し、ADR-0022 の全量列挙精度を上げる。

- backend: messages.json の blog キー(error 6 / success 3)と docs(api.md /
  data-model.md)を列挙に追加。逆に blog 専用の env・ErrorCode enum・タスク
  ハンドラは存在しないことを明記し、#519 が存在しない資産を探さないようにした
- Agent 波及を「入力契約の移行」として明確化。blog_context を前提にする
  prompt 2 本(agent_career_summary / agent_self_pr)と test 2 本(test_agent /
  test_agent_context_builder)を #519 で同一 PR 更新すると明記
- 「撤去の前提条件(#519 の実装ゲート)」節を追加。内部/外部消費者の不在確認を
  ゲート化し、消費者が居た場合は deprecation/migration へ切り替える方針を記載

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yusuke0610

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yusuke0610

Copy link
Copy Markdown
Owner Author

https://github.com/coderabbitai review

@yusuke0610
yusuke0610 merged commit ed797ac into main Jul 21, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ブログ撤去 1/2] ADR 起票: ブログ連携機能の撤去

1 participant