Fix build#244
Conversation
|
It looks like it works. EDIT |
|
@joshmoore ready |
| run: python -m pip list | ||
|
|
||
| - name: Run tests | ||
| run: pytest -v --pyargs numcodecs No newline at end of file |
There was a problem hiding this comment.
This is the only location currently running pytest on OS X, no?
There was a problem hiding this comment.
My bad. Only remark is that Github actions limit macos concurrent job to 5.
And wheel are tested using pytest, so it is not only one place.
There was a problem hiding this comment.
Gotcha. GitHub Action search only works on the logs that you've opened. Happy to have ci-osx.yml re-removed, but I'd propose let's not hold up this since others like @martindurant are having issues due to my 0.7.0 release.
| - name: test | ||
| run: | | ||
| ls | ||
| ls dist |
There was a problem hiding this comment.
Did you mean to try installing the wheel here? Or was this just temporary debugging?
There was a problem hiding this comment.
debug. It allow to check if all files are properly placed.
|
Awesome! Thanks so much Grzegorz! Also thanks Josh for reviewing and trying another release (looks like it is working 🎉). 😄 |
3 participants
[Description of PR]
fix #242
describen here #242 (comment)
TODO:
tox -e py38passes locallytox -e docspasses locally