Skip to content

Fix build #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmoore merged 5 commits into from
Sep 10, 2020
+30 −3
Merged

Fix build #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8158791
fix build
Czaki Sep 10, 2020
7aee882
add test run
Czaki Sep 10, 2020
a20789e
fix sdist build
Czaki Sep 10, 2020
e4a07d1
test sdist install
Czaki Sep 10, 2020
980f94b
restore ci-osx
Czaki Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-osx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python-version }}

- name: Install numcodecs
run: |
python -m pip install -U pip setuptools wheel pytest
Expand Down
31 changes: 29 additions & 2 deletions .github/workflows/wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ jobs:
name: Build source distribution
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v1
with:
submodules: true

- uses: actions/setup-python@v2
name: Install Python
Expand All @@ -52,19 +54,44 @@ jobs:
- name: Build sdist
run: python setup.py sdist

- name: test install
run: pip install dist/numcodecs*.tar.gz

- uses: actions/upload-artifact@v2
with:
path: dist/*.tar.gz

test_dist_pypi:
needs: [build_wheels, build_sdist]
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v1
with:
name: artifact
path: dist
- uses: actions/download-artifact@v1
with:
name: wheels
path: dist

- name: test
run: |
ls
ls dist

@joshmoore joshmoore Sep 10, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to try installing the wheel here? Or was this just temporary debugging?

@Czaki Czaki Sep 10, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug. It allow to check if all files are properly placed.


upload_pypi:
needs: [build_wheels, build_sdist]
runs-on: ubuntu-latest
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/v')
steps:
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v1
with:
name: artifact
path: dist
- uses: actions/download-artifact@v1
with:
name: wheels
path: dist

- uses: pypa/gh-action-pypi-publish@master
with:
Expand Down