Skip to content

issues: add pep-723 to issue template#3087

Merged
d-v-b merged 4 commits into
zarr-developers:mainfrom
ianhi:pep-723
May 25, 2025
Merged

issues: add pep-723 to issue template#3087
d-v-b merged 4 commits into
zarr-developers:mainfrom
ianhi:pep-723

Conversation

@ianhi

@ianhi ianhi commented May 23, 2025

Copy link
Copy Markdown
Contributor

Adds pep-723 compliant metadata to the placeholder for the reproducer in the bug report

You can see how it will render by making a new issue here: https://github.com/ianhi/git-expt/issues

image

closes: #2953

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 23, 2025
@d-v-b

d-v-b commented May 23, 2025

Copy link
Copy Markdown
Contributor

thoughts on whether the zarr version should point to main branch on github?

@ianhi

ianhi commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

I like that idea. I've pushed a change to do that, as well as moved it from placeholder text to value so that it's copy pastable by the user.

image

@d-v-b

d-v-b commented May 23, 2025

Copy link
Copy Markdown
Contributor

do we want to make it uv-specific? I think you can use regular pypi dependency syntax in the pep-723 block

@d-v-b

d-v-b commented May 23, 2025

Copy link
Copy Markdown
Contributor

e.g.

# /// script
# requires-python = ">=3.11"
# dependencies = [
#     "zarr@git+https://github.com/zarr-developers/zarr-python.git@main",
# ]
# ///

@ianhi

ianhi commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

Good catch. I used the generic form, I also linked to active docs as suggested by the PEP documetn

@d-v-b
d-v-b enabled auto-merge (squash) May 23, 2025 20:16
@d-v-b

d-v-b commented May 23, 2025

Copy link
Copy Markdown
Contributor

the upstream tests are failing right now because of incompatibility between s3fs and fsspec. I will merge this anyway

@d-v-b
d-v-b disabled auto-merge May 23, 2025 21:02
@d-v-b
d-v-b self-requested a review May 24, 2025 08:28
@d-v-b

d-v-b commented May 24, 2025

Copy link
Copy Markdown
Contributor

the upstream tests are failing right now because of incompatibility between s3fs and fsspec. I will merge this anyway

the github UI will not let me merge until the checks pass. I'm trying to sort out the upstream test failures here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add pep-723 inline metadata header to default bug report

2 participants