Updated strings, excluded strings from Localizable.strings which don't need to be translated#1268
Updated strings, excluded strings from Localizable.strings which don't need to be translated#1268michalrentka wants to merge 3 commits intozotero:masterfrom
Conversation
| "errors.citation.generate_bibliography" = "Could not generate bibliography"; | ||
| "errors.citation.invalid_types" = "Invalid item types selected"; | ||
| "errors.citation.missing_style" = "No citation style selected. Go to Settings → Quick Copy and select a new style."; | ||
| "errors.citation.open_settings" = "Open Settings"; |
There was a problem hiding this comment.
Some of these should remain translated. Anything that can happen in normal usage (e.g., because a selected style was removed) should stay translated. It's just message for unexpected internal errors that hopefully never happen that we don't need to bother translating.
There was a problem hiding this comment.
My bad, these should be localized. I'd keep "errors.citation.generate_bibliography" removed, it's a generic error that you can't really do anything about?
| "errors.pdf.incompatible_document" = "This document is not supported."; | ||
| "errors.pdf.empty_document" = "This document is empty."; | ||
| "errors.pdf.page_index_not_int" = "Incorrect format of page stored for this document"; | ||
| "errors.pdf.document_changed" = "This document has been changed on another device. Please reopen it to continue editing."; |
There was a problem hiding this comment.
At least some of these should remain as well.
There was a problem hiding this comment.
"errors.pdf.incompatible_document" is a bit misleading, it's used in html/epub reader actually (I'll rename it) when the document is not html/epub, but we do check that before we try to open the reader, so this is just an additional check to be 100% sure we're trying to open the right document. This shouldn't really happen.
"errors.pdf.empty_document" I guess it can be localized, but you can't really do anything about it? The document is "broken"
"errors.pdf.document_changed" should stay localized, sorry.
| "errors.shareext.file_not_pdf" = "Unable to save PDF"; | ||
| "errors.shareext.api_error" = "Error uploading item. The item was saved to your local library."; | ||
| "errors.shareext.webdav_error" = "Error uploading attachment to WebDAV server"; | ||
| "errors.shareext.webdav_not_verified" = "WebDAV verification error"; |
There was a problem hiding this comment.
I'm confused. Lots of these seem like normal user-facing errors?
There was a problem hiding this comment.
To be clear, it's not that any error message shouldn't be translated. This is specifically for internal error messages that users should never see unless something went very wrong. We don't need to make localizers translate those (among other things because it's hard to even explain what it's talking about).
There was a problem hiding this comment.
"errors.shareext.file_not_pdf" is actually not even used anymore, removed.
"errors.shareext.api_error" do we want this translated? It's a generic HTTP error handling, outside of the ones that we handle specifically (like 413 or 403).
"errors.shareext.webdav_error" same as above, it's generic webdav error, the webdav can be misconfigured or some other issue with it.
"errors.shareext.webdav_not_verified" adding back to localized
|
@dstillman now I'm a bit confused too :). In the #1221 issue you mentioned:
So I thought generic errors like I'm moving some other strings back to localized, but what do we do about generic messages like "Could not save note", "Unable to load libraries", "Could not remove item" etc.? They are there mostly because the database returned some error and shouldn't really happen. But the user will see them after the action failed to perform. |
michalrentka
force-pushed
the
localizations
branch
from
1554268 to
f3dea7f
Compare
|
@dstillman does it look better now? |
michalrentka
force-pushed
the
localizations
branch
from
f3dea7f to
e80cbd4
Compare
3 participants
@dstillman I created new files Messages.strings/.stringsdict and moved some messages from Localizable to Messages. I re-added the strings you removed and hardcoded. Feel free to glance over it and let me know whether you want me to move some other error messages around.
Closes #1221