Updating from upstream - #6
Merged
Merged
Conversation
…ges in comments (#63)
…up-chain (#59) * feat(ignore_copy_only_backups): Added in the option to ignore copy_only backups * fix(tests): resolving CS0854 error 'Error CS0854 An expression tree may not contain a call or invocation that uses optional arguments' * feat(ignore_copy_only_backups): Added a docstring for the `ignoreCopyOnlyBackups` parameter * deprecate(copy_only): removing feature to choose to add copy_only backups to chain Co-authored-by: Ryan Clare <rclare@factset.com> Co-authored-by: Alex Irion <alex.irion@factset.com>
* fix(striped_backups): changed logic to get all striped backups * test(striped_backups): adding a unit test for backup chains with striped backups * refactor(striped_backups): renames, comments and list handling based on PR suggestions * fix(striped_backups): return empty list if no diff backups * refactor(striped_backups): whitespace * fix(striped_backups): Exception on empty list of backups * fix(striped_backups): also a null check for the list of backups * test(striped_backups): few more thorough positive tests with stripes and duplicates * test(striped_backups): small rename in function * test(striped_backups): few negative tests * refactor(striped_backups): null/empty check for backup list * test(striped_backups): Adding back test for missing link * test(striped_backups): refactor the verify backup chain function * test(striped_backups): refactor `VerifyListIsAValidBackupChain()` * test(striped_backups): refactor duplicate file test to its own function * test(striped_backups): PR suggestions - refactor duplicate test + null check Co-authored-by: Alex Irion <alex.irion@factset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.