chore: codeowner and changetest#13962
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LHerskind
force-pushed
the
lh/scream-and-shout
branch
from
b0f60ee to
a1d8ab8
Compare
LHerskind
force-pushed
the
lh/scream-and-shout
branch
from
a1d8ab8 to
c91a586
Compare
Maddiaa0
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new test that do some minimal checks to catch if the contract code have been changed, and add the turtles as codeowners for the test.
That way, we should be able to somewhat avoid not noticing if there are changes made to the contracts. It only check a few of the contracts;
rollup,governanceandregistryas those are the big ones and should deal with most changes.I only do codeowners on this one file instead of the dir as we don't to be notified around extra tests or things that would not really cause a problem if used for nodes.