feat: initial gas bench gh#13986
Merged
Merged
Conversation
This was referenced May 1, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ludamad
reviewed
May 1, 2025
| if (cols[2] == "Max") { | ||
| # Get the function name | ||
| func_name = cols[1]; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It did the job, was available and mr robot was doing well with it
ludamad
reviewed
May 1, 2025
| } | ||
|
|
||
| function bench { | ||
| local hash=$(git rev-list -n 1 ${AZTEC_CACHE_COMMIT:-HEAD}) |
Collaborator
There was a problem hiding this comment.
There's already a content hash defined, we don't need to follow the inferior pattern of git commit
LHerskind
force-pushed
the
lh/gas-benchmarks
branch
from
4dc8c2a to
d4ebfcd
Compare
LHerskind
force-pushed
the
lh/gh-l1-benchmarks
branch
2 times, most recently
from
128076d to
39ae159
Compare
LHerskind
force-pushed
the
lh/gas-benchmarks
branch
from
d4ebfcd to
0aedec3
Compare
just-mitch
approved these changes
May 6, 2025
LHerskind
force-pushed
the
lh/gh-l1-benchmarks
branch
from
39ae159 to
4821c85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding benchmark reporting for some l1 gas numbers (see https://aztecprotocol.github.io/aztec-packages/dev/l1-gas-bench/).
Currently have removed the if, to see it being run on this pr and get it going.