Skip to content

chore(avm): Use PC alias type consistently#19625

Merged
jeanmon merged 1 commit into
merge-train/avmfrom
jm/use-pc-alias-type
Jan 15, 2026
Merged

chore(avm): Use PC alias type consistently#19625
jeanmon merged 1 commit into
merge-train/avmfrom
jm/use-pc-alias-type

Conversation

@jeanmon

@jeanmon jeanmon commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

This alias type was only used partially (e.g. in internal_call_stack_manager)

@jeanmon jeanmon changed the base branch from next to merge-train/avm January 15, 2026 13:05
@jeanmon jeanmon force-pushed the jm/use-pc-alias-type branch from 395ae80 to 7f20115 Compare January 15, 2026 13:12
@jeanmon jeanmon marked this pull request as ready for review January 15, 2026 13:21
@jeanmon jeanmon removed the request for review from IlyasRidhuan January 15, 2026 13:21
@AztecBot

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 3 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/bcf158a85140cd15�bcf158a85140cd158;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "committee member invalidates a block if proposer does not come through" (95s) (code: 1) group:e2e-p2p-epoch-flakes (\033jeanmon\033: Use PC alias type consistently)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/7138493af7c5d3b3�7138493af7c5d3b38;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_high_tps_block_building.test.ts (286s) (code: 1) group:e2e-p2p-epoch-flakes (\033jeanmon\033: Use PC alias type consistently)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/161df9a09606a332�161df9a09606a3328;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "proposer invalidates multiple blocks" (603s) (code: 124) group:e2e-p2p-epoch-flakes (\033jeanmon\033: Use PC alias type consistently)

@fcarreiro fcarreiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the type is defined in common/

@jeanmon

jeanmon commented Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

LGTM assuming the type is defined in common/

Yes it is defined in vm2/common/aztec_types.hpp

@jeanmon jeanmon merged commit 86e2ae7 into merge-train/avm Jan 15, 2026
12 of 13 checks passed
@jeanmon jeanmon deleted the jm/use-pc-alias-type branch January 15, 2026 14:37
@AztecBot AztecBot mentioned this pull request Jan 15, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 17, 2026
BEGIN_COMMIT_OVERRIDE
feat(avm): contract instance mutation (#19499)
fix(avm): Fix note hash exists fuzzing (#19616)
fix(avm): Build trace on coverage prover runs (#19627)
chore(avm): Use PC alias type consistently (#19625)
feat(avm): mutate global gas fees and timestamp (#19500)
docs: avm docs (#19603)
fix(avm): Increase chances of fuzzer finding limits (#19656)
fix(avm)!: de-risk memory injection attacks (#19620)
fix(avm): Fix TS ECC add infinity handling (#19657)
fix(avm): Fix jumpif in fuzzer (#19655)
feat(avm): protocol contractg mutations (#19586)
chore(avm): analyze fuzzer corpus distribution (#19614)
feat(avm): fuzzer treats enqueued call size as coverage (#19615)
refactor(avm): Refactor calldata copy and return data copy fuzzing
(#19666)
feat(avm): boundary values for mutations (#19617)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants