fix(avm): Fix TS ECC add infinity handling#19657
Merged
Merged
Conversation
sirasistant
requested review from
IlyasRidhuan,
dbanks12,
fcarreiro and
jeanmon
as code owners
sirasistant
requested review from
MirandaWood
and removed request for
dbanks12,
fcarreiro and
jeanmon
MirandaWood
approved these changes
Jan 16, 2026
| let dest; | ||
| if (p1IsInfinite) { | ||
| if (p1IsInfinite && p2IsInfinite) { | ||
| dest = Point.ZERO; |
Contributor
There was a problem hiding this comment.
Ahh, I see why this all failed previously... Point.ZERO is not really the point at infinity (the Point class stores isInfinite = false for ZERO, which is never passed to bb anyway). Maybe tracking a destIsInfinite in this nested if would be better so we can override more robustly at the end?
Anyway! This is great for now, good find!!
Contributor
Author
There was a problem hiding this comment.
yeah wanted to do a minimal fix since it's on the old ts codebase
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 17, 2026
BEGIN_COMMIT_OVERRIDE feat(avm): contract instance mutation (#19499) fix(avm): Fix note hash exists fuzzing (#19616) fix(avm): Build trace on coverage prover runs (#19627) chore(avm): Use PC alias type consistently (#19625) feat(avm): mutate global gas fees and timestamp (#19500) docs: avm docs (#19603) fix(avm): Increase chances of fuzzer finding limits (#19656) fix(avm)!: de-risk memory injection attacks (#19620) fix(avm): Fix TS ECC add infinity handling (#19657) fix(avm): Fix jumpif in fuzzer (#19655) feat(avm): protocol contractg mutations (#19586) chore(avm): analyze fuzzer corpus distribution (#19614) feat(avm): fuzzer treats enqueued call size as coverage (#19615) refactor(avm): Refactor calldata copy and return data copy fuzzing (#19666) feat(avm): boundary values for mutations (#19617) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzzer revealed issues in infinity handling in ts