chore: documentation fixes for ECCVM after first external audit#20348
Merged
notnotraju merged 23 commits intoMar 12, 2026
Merged
chore: documentation fixes for ECCVM after first external audit#20348notnotraju merged 23 commits into
notnotraju merged 23 commits into
Conversation
- Line 181: nP and -nP share the same x-coordinate (not y), y-coordinates differ by sign
- Line 443: swap LHS/RHS in precompute constraint equation (multiples decrease by row)
- Lines 158, 178, 351: skew is subtracted, not added
- Line 391: skew value range is {0,7}, not {0,1}
- Line 411: remove ∪ {0} from wNAF digit range (digits are always odd)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 62: remove incorrect claim that ecc_point_table_relation is gated by precompute_select - Line 81: rename s0/s1 to hi/lo in convert_to_wnaf to avoid confusion with broader context Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 274: is_add is not conditioned on op_code; used for both add and MSM operations - Line 310: fix transcript_add_lambda -> transcript_msm_lambda (block validates MSM lambda) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 263: fix max(deg(xa, xb)) -> max(deg(xa), deg(xb))
- Line 371: add missing fourth double() call
- Line 41: fix @param evals -> @param accumulator
- Line 469: fix round_transition != 1 -> round_transition != 0
- Line 520: fix msm_transition -> msm_transition_shift
- Line 23: fix s_{j,i} -> a_{j,i} for wNAF slices
- Line 166: separate point 5 from precompute_select == 1 umbrella
- Line 229: clarify tuple is added when msm_transition_shift == 1
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 141: point table order and index are incorrect; added AUDITTODO to verify Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 564: slope is undefined when either point is at infinity; numerator/denominator are not modified in degenerate cases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Line 523: transcript_accumulator_not_empty == 1 means NOT at infinity (was flipped) - Line 528: transcript_base_y_inverse checks transcript_add_y_equal (not x_equal) - Line 515: scalar = z1 - lambda*z2 (not + lambda*z2) - Line 547: fix duplicate precompute_tx -> precompute_ty Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…k/eccvm-external-audit-1-documentation # Conflicts: # barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_msm_relation_impl.hpp
…pt_relation_impl.hpp add_result_is_infinity was a duplicate of result_infinity_from_operation
…cumulator_trace to point-at-infinity
…scalar == POINT_TABLE_SIZE / 2.
notnotraju
force-pushed
the
rk/eccvm-external-audit-1-documentation
branch
from
d6064a0 to
3b108e1
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
notnotraju
force-pushed
the
rk/eccvm-external-audit-1-documentation
branch
from
3b108e1 to
76f3009
Compare
added 5 commits
March 12, 2026 12:05
…ztec-packages into rk/eccvm-external-audit-1-documentation
- ECCVM_RECURSIVE_VERIFIER_GATE_COUNT: 224707 → 224657
…ztec-packages into rk/eccvm-external-audit-1-documentation
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
BEGIN_COMMIT_OVERRIDE chore: unify tests in ecc/curves and ecc/groups (#21392) chore: `ecc/fields` ASM audit (#20892) chore: audit the `ecc/field` extension field (#21409) chore: responding to external IPA audit (#20334) feat: committed sumcheck for batched Hiding Translator (#21376) chore: documentation fixes for ECCVM after first external audit (#20348) chore: Document RAM gate cost optimization opportunity (#21426) refactor: rename MSGPACK_FIELDS to SERIALIZATION_FIELDS (#21175) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One edit per commit.