Skip to content

refactor: rename MSGPACK_FIELDS to SERIALIZATION_FIELDS#21175

Merged
johnathan79717 merged 4 commits into
merge-train/barretenbergfrom
claudebox/rename-msgpack-fields-macro
Mar 12, 2026
Merged

refactor: rename MSGPACK_FIELDS to SERIALIZATION_FIELDS#21175
johnathan79717 merged 4 commits into
merge-train/barretenbergfrom
claudebox/rename-msgpack-fields-macro

Conversation

@AztecBot

@AztecBot AztecBot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Renames the MSGPACK_FIELDS macro to SERIALIZATION_FIELDS throughout the barretenberg codebase and the Noir ACIR codegen, since the macro is also used by read() and write() serialization — not just msgpack.

50 C++ files updated (306 replacements) plus corresponding references in the Noir ACIR C++ codegen (acvm-repo/acir/src/lib.rs).

ClaudeBox log: http://ci.aztec-labs.com/23152dd90800b8e9-1

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 5, 2026
@johnathan79717 johnathan79717 marked this pull request as ready for review March 5, 2026 16:41
@johnathan79717 johnathan79717 requested review from johnathan79717 and ludamad and removed request for IlyasRidhuan, fcarreiro and jeanmon March 5, 2026 16:41
@johnathan79717

johnathan79717 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

/claudebox resolve conflicts

@AztecBot

AztecBot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

⏳ Run #1 — Session completed (2m)
Live status

Resolved 1 conflict in barretenberg/cpp/src/barretenberg/vm2/common/avm_io.hpp and rebased onto latest next. Details: https://gist.github.com/AztecBot/09a21b92f87d0c9fccd7cb34f80fb5a9

@AztecBot AztecBot force-pushed the claudebox/rename-msgpack-fields-macro branch from ccdfa86 to 1f37d59 Compare March 12, 2026 11:55
@johnathan79717 johnathan79717 changed the base branch from next to merge-train/barretenberg March 12, 2026 11:56
@johnathan79717

johnathan79717 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

/claudebox fix CI failures

@AztecBot

AztecBot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

⏳ Run #1 — Session completed (4m)
Live status

Fixed CI — 2 MSGPACK_FIELDS usages in bbapi_chonk.hpp were missed in the rename to SERIALIZATION_FIELDS, causing all C++ builds to fail. Pushed the fix to #21175. Details: https://gist.github.com/AztecBot/7a3bf435b63651bb691ae89f550223f5

@johnathan79717

johnathan79717 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

/claudebox you forgot to clang format. Remember that in CLAUDE.md or MEMORY.md

@AztecBot

AztecBot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

⏳ Run #1 — Session completed (<1m)
Live status

Saved to memory — I'll always run clang-format on C++ files before creating PRs going forward. Won't forget again.

@johnathan79717

johnathan79717 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

/claudebox then fix the clang format in this PR

@AztecBot

AztecBot commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

⏳ Run #1 — Session completed (3m)
Live status

Fixed clang-format violations in 17 C++ files caused by the longer SERIALIZATION_FIELDS macro name. Pushed to #21175. Details: https://gist.github.com/AztecBot/09fd05456ce4f025cee9a3f30e0c0234

@johnathan79717 johnathan79717 merged commit 21540a2 into merge-train/barretenberg Mar 12, 2026
10 checks passed
@johnathan79717 johnathan79717 deleted the claudebox/rename-msgpack-fields-macro branch March 12, 2026 17:17
@AztecBot AztecBot mentioned this pull request Mar 12, 2026
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Mar 12, 2026
@AztecBot
feat: merge-train/barretenberg (#21406)
a083101 
BEGIN_COMMIT_OVERRIDE
chore: unify tests in ecc/curves and ecc/groups (#21392)
chore: `ecc/fields` ASM audit (#20892)
chore: audit the `ecc/field` extension field (#21409)
chore: responding to external IPA audit (#20334)
feat: committed sumcheck for batched Hiding Translator (#21376)
chore: documentation fixes for ECCVM after first external audit (#20348)
chore: Document RAM gate cost optimization opportunity (#21426)
refactor: rename MSGPACK_FIELDS to SERIALIZATION_FIELDS (#21175)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludamad ludamad Awaiting requested review from ludamad

1 more reviewer

@johnathan79717 johnathan79717 johnathan79717 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AztecBot @johnathan79717