chore: unify tests in ecc/curves and ecc/groups#21392
Merged
Merged
Conversation
federicobarbacovi
approved these changes
Mar 12, 2026
federicobarbacovi
left a comment
federicobarbacovi
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for doing this! Only one comment
| } | ||
| } | ||
|
|
||
| TEST(g1, Serialize) |
Contributor
There was a problem hiding this comment.
Do we test this serialisation somewhere else?
Contributor
Author
There was a problem hiding this comment.
Yes, it is being tested in test_read_write_buffer in affine_element.test.cpp so we can safely remove the test you mentioned.
This was referenced Mar 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
BEGIN_COMMIT_OVERRIDE chore: unify tests in ecc/curves and ecc/groups (#21392) chore: `ecc/fields` ASM audit (#20892) chore: audit the `ecc/field` extension field (#21409) chore: responding to external IPA audit (#20334) feat: committed sumcheck for batched Hiding Translator (#21376) chore: documentation fixes for ECCVM after first external audit (#20348) chore: Document RAM gate cost optimization opportunity (#21426) refactor: rename MSGPACK_FIELDS to SERIALIZATION_FIELDS (#21175) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Templates tests for common ecc operations in
ecc/groupsinstead of duplicated tests for each curve.