fix: restore test execution in ci-barretenberg CI modes#22303
Merged
Conversation
PR #22061 switched ci-barretenberg from calling bootstrap.sh ci (which builds AND runs tests) to make targets that only collect test commands into /tmp/test_cmds without starting the test engine to execute them. This meant BB tests silently stopped running on merge-train/barretenberg PRs. Revert to calling bootstrap.sh ci directly. For ci-barretenberg, add explicit CRS download (the original motivation for #22061). For ci-barretenberg-full, barretenberg/bootstrap.sh already handles CRS download in bootstrap_all.
AztecBot
added
ci-draft
ludamad
approved these changes
Apr 3, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 4, 2026
BEGIN_COMMIT_OVERRIDE chore: upgrade uintx assert to run in release (#22289) chore: Fix log statement in ECDSA test (#22285) fix: avoid oob access in RAM / ROM and enable soft-fail (#22301) fix: restore test execution in ci-barretenberg CI modes (#22303) fix: minor fixes pt. 5 (#22306) chore: comment about standard behavior for de bruijn (#22310) fix: null socket on bb process exit/error in native_socket.ts (#22309) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #22061 switched
ci-barretenbergandci-barretenberg-fullfrom callingbootstrap.sh ci(which builds AND runs tests viaparallelize) to Make targets that only collect test commands into/tmp/test_cmdswithout ever starting the test engine to execute them. This meant BB tests silently stopped running on allmerge-train/barretenbergPRs.Fix: Revert to calling
bootstrap.sh cidirectly.ci-barretenberg: Add explicit CRS download beforebarretenberg/cpp/bootstrap.sh ci(preserving the CRS fix that refactor: use Make targets for ci-barretenberg CI paths #22061 was trying to solve)ci-barretenberg-full: Revert tobarretenberg/bootstrap.sh ci(which already downloads CRS viabootstrap_all)Test plan
ci-barretenberglabel triggers build + test execution (not just build)ci-barretenberg-fulllabel triggers full build + test executionClaudeBox log: https://claudebox.work/s/0b1cdb0a4d7a7f5a?run=2