fix: disable max capacity test in debug + tiny gate separator improvements#22215
Merged
Merged
Conversation
iakovenkos
commented
Apr 1, 2026
iakovenkos
commented
Contributor
- Max chonk capacity test is very heavy, and running it in nightly debug is not really needed
- Noticed that we're still using log_n independent challenges for eccvm, translator, and batched honk-translator, switched to using dyadic power of a single challenge, as it's done elsewhere
- Noticed that previously introduced a redundnt gate separator in the batched flow - MegaZK sumcheck path can re-use translator's gate separator
…m redundant gate sep from batched prover
iakovenkos
commented
Apr 1, 2026
| GateSeparatorPolynomial<FF> translator_gate_sep(gate_challenges, JOINT_LOG_N); | ||
| // Single gate separator for both circuits: beta_products has size 2^JOINT_LOG_N which covers | ||
| // both the MegaZK real rounds (2^mega_zk_log_n) and translator rounds (2^JOINT_LOG_N). | ||
| GateSeparatorPolynomial<FF> gate_sep(gate_challenges, JOINT_LOG_N); |
Contributor
Author
There was a problem hiding this comment.
more of a clean up than an opt tbh
iakovenkos
commented
Apr 1, 2026
federicobarbacovi
approved these changes
Apr 1, 2026
federicobarbacovi
left a comment
federicobarbacovi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for this!
AztecBot
added a commit
that referenced
this pull request
Apr 2, 2026
The MaxCapacityPassing test accumulates 17 app circuits and is extremely heavy. In debug builds (nightly debug CI), it causes OOM/timeout failures. This test is only meaningful in release builds. Mirrors the fix from PR #22215 which is in merge-train/barretenberg but hasn't reached next yet.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
BEGIN_COMMIT_OVERRIDE fix: verify accumulated pairing points in native ChonkVerifier (#22224) chore: enable _GLIBCXX_DEBUG in debug build presets (#22218) feat: add --memory_profile_out flag for Chonk memory profiling (#22145) fix: disable max capacity test in debug + tiny gate separator improvements (#22215) fix: WASM build for memory_profile.cpp (#22231) fix: translator audit fixes (#22242) fix: remove constexpr from functions using std::vector for _GLIBCXX_DEBUG compat (#22239) fix: pippenger edge case (#22256) fix: avoid dereferencing past-the-end vector iterators in serialize.hpp (#22261) chore: crypto primitives external audit response 0 (#22263) feat: switch memory profiling from peak RSS to live heap usage (#22266) fix: replace UB end-iterator dereference in serialize.hpp (#22262) fix: catch exceptions in ChonkBatchVerifier::batch_check (#22270) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.