fix: translator audit fixes#22242
Merged
Merged
Conversation
…ransferRelation Replace L_real_last with L_last_in_minicircuit in subrelations 1-8 to match the code.
Add BB_ASSERT to guard against overflow exceeding SORTED_STEPS_COUNT per group in ordered polynomial construction.
Add compute_negative_modulus_limbs<FF>() on TranslatorCircuitBuilder and use it from the relation impl instead of independently recomputing.
suyash67
force-pushed
the
sb/translator-fixes
branch
from
f572c54 to
0ebc136
Compare
Ensures infinity points are consistently mapped to (0,0) in witness generation, matching the accumulator precomputation code path.
Add missing z_perm to the polynomial listing. The original count of 91 was missing the grand product polynomial used by the permutation argument.
suyash67
force-pushed
the
sb/translator-fixes
branch
from
0ebc136 to
cd93ed3
Compare
iakovenkos
reviewed
Apr 2, 2026
| } | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
thanks for adding this check!
iakovenkos
approved these changes
Apr 2, 2026
iakovenkos
left a comment
iakovenkos
left a comment
Contributor
There was a problem hiding this comment.
everything looks good!
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
BEGIN_COMMIT_OVERRIDE fix: verify accumulated pairing points in native ChonkVerifier (#22224) chore: enable _GLIBCXX_DEBUG in debug build presets (#22218) feat: add --memory_profile_out flag for Chonk memory profiling (#22145) fix: disable max capacity test in debug + tiny gate separator improvements (#22215) fix: WASM build for memory_profile.cpp (#22231) fix: translator audit fixes (#22242) fix: remove constexpr from functions using std::vector for _GLIBCXX_DEBUG compat (#22239) fix: pippenger edge case (#22256) fix: avoid dereferencing past-the-end vector iterators in serialize.hpp (#22261) chore: crypto primitives external audit response 0 (#22263) feat: switch memory profiling from peak RSS to live heap usage (#22266) fix: replace UB end-iterator dereference in serialize.hpp (#22262) fix: catch exceptions in ChonkBatchVerifier::batch_check (#22270) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/updates addressing findings from translator audit.