Skip to content

chore: Fix log statement in ECDSA test#22285

Merged
federicobarbacovi merged 1 commit into
merge-train/barretenbergfrom
fb/fix_logging_ecdsa_test
Apr 3, 2026
Merged

chore: Fix log statement in ECDSA test#22285
federicobarbacovi merged 1 commit into
merge-train/barretenbergfrom
fb/fix_logging_ecdsa_test

Conversation

@federicobarbacovi

Copy link
Copy Markdown
Contributor

When testing ECDSA signatures with a random private key, we were logging the fixed private key. This PR fixes the logging so that we log the randomly generated private key.

@federicobarbacovi federicobarbacovi self-assigned this Apr 2, 2026
@federicobarbacovi federicobarbacovi marked this pull request as ready for review April 2, 2026 18:21
@federicobarbacovi federicobarbacovi enabled auto-merge (squash) April 2, 2026 18:21
@federicobarbacovi federicobarbacovi merged commit 2affcb2 into merge-train/barretenberg Apr 3, 2026
18 checks passed
@federicobarbacovi federicobarbacovi deleted the fb/fix_logging_ecdsa_test branch April 3, 2026 08:48
github-merge-queue Bot pushed a commit that referenced this pull request Apr 4, 2026
BEGIN_COMMIT_OVERRIDE
chore: upgrade uintx assert to run in release (#22289)
chore: Fix log statement in ECDSA test (#22285)
fix: avoid oob access in RAM / ROM and enable soft-fail (#22301)
fix: restore test execution in ci-barretenberg CI modes (#22303)
fix: minor fixes pt. 5 (#22306)
chore: comment about standard behavior for de bruijn (#22310)
fix: null socket on bb process exit/error in native_socket.ts (#22309)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants