fix: minor fixes pt. 5#22306
Merged
Merged
Conversation
ludamad
approved these changes
Apr 3, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 4, 2026
BEGIN_COMMIT_OVERRIDE chore: upgrade uintx assert to run in release (#22289) chore: Fix log statement in ECDSA test (#22285) fix: avoid oob access in RAM / ROM and enable soft-fail (#22301) fix: restore test execution in ci-barretenberg CI modes (#22303) fix: minor fixes pt. 5 (#22306) chore: comment about standard behavior for de bruijn (#22310) fix: null socket on bb process exit/error in native_socket.ts (#22309) END_COMMIT_OVERRIDE
johnathan79717
added a commit
that referenced
this pull request
Apr 7, 2026
## Summary Addresses findings from the polynomials/ module security audit (https://github.com/AztecProtocol/barretenberg-claude/issues/2383). - **F1** (Low): Harden file-backed polynomial memory: restrict temp file permissions to `0600`, add `O_EXCL` to prevent race conditions, use `MAP_PRIVATE` instead of `MAP_SHARED` - **F4** (Info): Guard `compute_linear_polynomial_product` against `n=0` to prevent underflow - **F5** (Info): Clarify `UnivariateCoefficientBasis` docstring to distinguish Karatsuba precomputation from polynomial coefficients **Already fixed upstream:** - **F2** (Low): `factor_roots` empty polynomial guard (in #22282) - **F3** (Info): `get_scratch_space` thread safety via mutex (in #22306)
critesjosh
pushed a commit
that referenced
this pull request
Apr 14, 2026
## Summary Addresses findings from the polynomials/ module security audit (AztecProtocol/barretenberg-claude#2383). - **F1** (Low): Harden file-backed polynomial memory: restrict temp file permissions to `0600`, add `O_EXCL` to prevent race conditions, use `MAP_PRIVATE` instead of `MAP_SHARED` - **F4** (Info): Guard `compute_linear_polynomial_product` against `n=0` to prevent underflow - **F5** (Info): Clarify `UnivariateCoefficientBasis` docstring to distinguish Karatsuba precomputation from polynomial coefficients **Already fixed upstream:** - **F2** (Low): `factor_roots` empty polynomial guard (in #22282) - **F3** (Info): `get_scratch_space` thread safety via mutex (in #22306)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrivateExecutionStepRaw::loadandparse_uncompressed, with red/green tests inbbapi.test.cppBB_ASSERT_GTEguards inPolynomial::shiftable()to prevent unsigned underflow whensize < NUM_ZERO_ROWSBB_ASSERTinscale_by_generatorthatgenerator_size % num_threads == 0to prevent silent element skiprow_disabling_polynomial.hppevaluate_at_challengeto takestd::span<const FF>instead of by-valuestd::vector<FF>/ non-conststd::span<FF>msgto assertions inevaluate_linear_identityandevaluate_polynomial_identityconstant pathsfield_t::invert()for constant inputs to avoid fragile null context dereference