fix(spartan): drop broken Terraform validations on RPC ingress vars#22792
Closed
AztecBot wants to merge 1 commit into
Closed
fix(spartan): drop broken Terraform validations on RPC ingress vars#22792AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-tracks the same fix as #22786 directly to
nextso the nightlynext-netdeploy stops failing while the merge-train/spartan PR (#22779) is still open.Failure
Last two
Deploy Next Netruns (https://github.com/AztecProtocol/aztec-packages/actions/runs/24948697881 and https://github.com/AztecProtocol/aztec-packages/actions/runs/24922876413, both at SHAa4ac021) failed duringterraform planfordeploy-aztec-infra. The rollup-contracts deploy job succeeded (L1 contracts landed on Sepolia, registry0x65ce7C5526Fe199e303B2Da7AfE96Bc9c066c7Eb), but no validators, provers, RPC, or bots were ever scheduled in thenext-netnamespace.Root cause
The
RPC_INGRESS_LOG_SAMPLE_RATEvariable added in #21591 has this validation:||does not short-circuit inside a Terraform validationcondition— Terraform eagerly evaluates thevar.X >= 0subexpression, andnull >= 0errors withargument must not be null, aborting the plan.next-net.envdoes not set this var, sodeploy_network.shwrites the default literalnullinto the generatedterraform.tfvars, which trips the validation.Fix
Drop the validation blocks on the variables that #21591 added:
RPC_INGRESS_LOG_SAMPLE_RATEandRPC_INGRESS_SESSION_AFFINITY. Both are forwarded into the GCE BackendConfig, which validates the values server-side. Identical to the diff in #22786.ClaudeBox log: https://claudebox.work/s/929873c3e6b22a40?run=1