chore: numeric audit response#22856
Merged
ledwards2225 merged 8 commits intoMay 1, 2026
Merged
Conversation
suyash67
reviewed
Apr 30, 2026
| constexpr uint256_t uint256_t::slice(const uint64_t start, const uint64_t end) const | ||
| { | ||
| assert(start < end); | ||
| BB_ASSERT_DEBUG(start <= end); |
Contributor
There was a problem hiding this comment.
Do we want start < end or start <= end?
When start = end the result is 0 and I am not sure if it should be 0 or the bit at index start = end.
Contributor
Author
There was a problem hiding this comment.
I went back and forth but I think a size-0 slice is a valid call and I think you'd expect it to return 0. The size-1 slice of form [start, start+1) would return the bit at index start
suyash67
approved these changes
Apr 30, 2026
suyash67
left a comment
suyash67
left a comment
Contributor
There was a problem hiding this comment.
Looks good, left a minor comment
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
May 6, 2026
BEGIN_COMMIT_OVERRIDE
fix(ci): default S3_BUILD_CACHE_AWS_PARAMS in cache_s3_transfer{,_to}
(AztecProtocol#22898)
chore: low-hanging chonk prover fixes from profiling (AztecProtocol#22855)
chore: fuse N `add_scaled` into one `parallel_for` (AztecProtocol#22893)
feat: Delayed merge implementation (AztecProtocol#22775)
chore: numeric audit response (AztecProtocol#22856)
fix: harden BN254 G2 SRS ingress (AztecProtocol#22858)
fix: remove unused hash_challenge variable in batch_merge.test.cpp
(AztecProtocol#22906)
fix(bbup): remove jq dependency (AztecProtocol#22912)
chore: fix g2 test failing on merge-train (AztecProtocol#22920)
fix(ci): error on disabled-cache in CI hash calculation (AztecProtocol#22904)
END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses external audit findings for numeric module (all low or informational).