Skip to content

fix(bbup): remove jq dependency#22912

Merged
ludamad merged 1 commit into
merge-train/barretenbergfrom
claudebox/bbup-remove-jq
May 2, 2026
Merged

fix(bbup): remove jq dependency#22912
ludamad merged 1 commit into
merge-train/barretenbergfrom
claudebox/bbup-remove-jq

Conversation

@AztecBot

@AztecBot AztecBot commented May 2, 2026

Copy link
Copy Markdown
Collaborator

Closes #22533.

bbup failed on systems without jq installed:

/root/.bb/bbup: line 54: jq: command not found
✗ No version specified and couldn't determine version from noir

bb-versions.json is a flat "<noir-version>": "<bb-version>" map with one entry per line, so the lookup can be done with a grep + cut pipeline that mirrors the style already used elsewhere in this script for parsing GitHub release JSON (see lines 45 / 47 / 207 / 209 — all use cut -d'"' -f4).

As a small side benefit, missing keys now resolve to an empty string (caught by the existing [ -z "$version" ] check), instead of the literal string "null" that jq -r produces.

Verified locally that the new pipeline produces identical output to jq -r --arg version "$v" '.[$version]' for every key in bb-versions.json and returns empty for nonexistent keys.

Closes #22533

ClaudeBox log: https://claudebox.work/s/ee6e4282b260d539?run=2

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 2, 2026
@ludamad ludamad marked this pull request as ready for review May 2, 2026 18:46
@ludamad ludamad enabled auto-merge (squash) May 2, 2026 19:33
@ludamad ludamad merged commit 88b9da9 into merge-train/barretenberg May 2, 2026
31 of 39 checks passed
@ludamad ludamad deleted the claudebox/bbup-remove-jq branch May 2, 2026 19:34
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request May 6, 2026
BEGIN_COMMIT_OVERRIDE
fix(ci): default S3_BUILD_CACHE_AWS_PARAMS in cache_s3_transfer{,_to}
(AztecProtocol#22898)
chore: low-hanging chonk prover fixes from profiling (AztecProtocol#22855)
chore: fuse N `add_scaled` into one `parallel_for` (AztecProtocol#22893)
feat: Delayed merge implementation (AztecProtocol#22775)
chore: numeric audit response (AztecProtocol#22856)
fix: harden BN254 G2 SRS ingress (AztecProtocol#22858)
fix: remove unused hash_challenge variable in batch_merge.test.cpp
(AztecProtocol#22906)
fix(bbup): remove jq dependency (AztecProtocol#22912)
chore: fix g2 test failing on merge-train (AztecProtocol#22920)
fix(ci): error on disabled-cache in CI hash calculation (AztecProtocol#22904)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants