fix: remove unused hash_challenge variable in batch_merge.test.cpp#22906
Merged
federicobarbacovi merged 1 commit intoMay 1, 2026
Merged
Conversation
AztecBot
added
ci-draft
federicobarbacovi
approved these changes
May 1, 2026
federicobarbacovi
merged commit 3952163
into
merge-train/barretenberg
47 of 55 checks passed
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
May 6, 2026
BEGIN_COMMIT_OVERRIDE
fix(ci): default S3_BUILD_CACHE_AWS_PARAMS in cache_s3_transfer{,_to}
(AztecProtocol#22898)
chore: low-hanging chonk prover fixes from profiling (AztecProtocol#22855)
chore: fuse N `add_scaled` into one `parallel_for` (AztecProtocol#22893)
feat: Delayed merge implementation (AztecProtocol#22775)
chore: numeric audit response (AztecProtocol#22856)
fix: harden BN254 G2 SRS ingress (AztecProtocol#22858)
fix: remove unused hash_challenge variable in batch_merge.test.cpp
(AztecProtocol#22906)
fix(bbup): remove jq dependency (AztecProtocol#22912)
chore: fix g2 test failing on merge-train (AztecProtocol#22920)
fix(ci): error on disabled-cache in CI hash calculation (AztecProtocol#22904)
END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the merge-train/barretenberg merge-queue failure: http://ci.aztec-labs.com/1617122ce095114b
Summary
compute_running_hashinbatch_merge.test.cpp(added by #22775) declaredbb::fr hash_challenge(0)but never used it. Under-Werror -Wall, the ARM build fails with[-Wunused-variable]. The fix removes the dead declaration.Why ci-full on #22775 didn't catch it
Clang's
-Wunused-variableis suppressed when a variable's constructor has visible side effects. On x86 (DISABLE_ASM=OFF),field<T>constructors callself_to_montgomery_form()→operator*=→asm_self_mul_with_coarse_reduction, which contains an__asm__()block with a"memory"clobber. Clang treats inline asm as a side effect and silences the warning.On ARM,
CMakeLists.txtauto-setsDISABLE_ASM=ON(line 50–57), sobb::fr(0)resolves to a pureconstexprarithmetic path with no observable side effect — clang then issues the warning.ci-full(label) runs only on amd64 (seeci.shfulltarget — singlebootstrap_ec2 ci-fullon x86), so the asm side-effect masked the warning. The merge queue (ci.sh merge-queue) is what adds the arm64 leg (a1-fast arm64 ci-fast), which is why the failure surfaced only at merge time.ClaudeBox log: https://claudebox.work/s/e0102d5ad296fd89?run=1