fix: slash attestations for invalid checkpoint proposals#23506
Merged
alexghr merged 1 commit intoMay 27, 2026
Merged
Conversation
alexghr
force-pushed
the
ag/fix-slash-attestations-for-invalid-checkpoint-proposals
branch
3 times, most recently
from
bb0d580 to
ad87bb1
Compare
alexghr
force-pushed
the
ag/fix-slash-attestations-for-invalid-checkpoint-proposals
branch
7 times, most recently
from
bfb0156 to
e9d865a
Compare
spalladino
reviewed
May 26, 2026
Comment on lines
+778
to
+780
| if (this.config.slashAttestInvalidCheckpointProposalPenalty > 0n) { | ||
| this.markInvalidProposalSlot(proposal.slotNumber); | ||
| } |
Contributor
There was a problem hiding this comment.
I guess the next PR is removing this conditional, right?
| }; | ||
|
|
||
| export class AttestedInvalidProposalWatcher extends (EventEmitter as new () => WatcherEmitter) implements Watcher { | ||
| private readonly log: Logger = createLogger('attested-invalid-proposal-watcher'); |
Contributor
There was a problem hiding this comment.
Nit: let's pass the logger bindings from the parent. Useful for distinguishing between nodes in e2e tests.
alexghr
force-pushed
the
ag/fix-slash-attestations-for-invalid-checkpoint-proposals
branch
from
e9d865a to
f285211
Compare
alexghr
force-pushed
the
ag/fix-slash-attestations-for-invalid-checkpoint-proposals
branch
from
f285211 to
36b86e2
Compare
alexghr
deleted the
ag/fix-slash-attestations-for-invalid-checkpoint-proposals
branch
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE fix(archiver): skip descendants of invalid-attestations checkpoints (AztecProtocol#23502) chore: scale network validators (AztecProtocol#23579) fix(ci): nightly 10 TPS bench GCP auth and checkout (AztecProtocol#23586) chore: set eth node resource profile (AztecProtocol#23583) fix: wait for checkpoint before sentinel assertions (AztecProtocol#23573) fix: slash attestations for invalid checkpoint proposals (AztecProtocol#23506) test: fix web3signer pipelining `e2e_multi_validator_node_key_store.test.ts` (AztecProtocol#23568) fix: cap CI devbox hostname (AztecProtocol#23591) test: stabilize invalid checkpoint descendant e2e (AztecProtocol#23582) test(e2e): stabilize invalidation slots in `proposer invalidates multiple checkpoints` (AztecProtocol#23590) test(e2e): stabilize invalid proposal slashing target slot in `attested_invalid_proposal` (AztecProtocol#23589) chore(foundation): faster toBufferBE via zero fast-path (AztecProtocol#23592) fix: honour BB_BINARY_PATH (AztecProtocol#23570) chore: bump reth and lighthouse (AztecProtocol#23588) chore: add web3signer and postgres node selectors (AztecProtocol#23598) fix: do not symlink .codex folders (AztecProtocol#23593) chore: fix claude and codex symlinking tests (AztecProtocol#23599) test(e2e): narrow down sentinel check in `multiple_validators_sentinel` (AztecProtocol#23604) test(e2e): fix `proposer invalidates multiple checkpoints` timeout (AztecProtocol#23608) fix: record zero-amount slashing offenses (AztecProtocol#23556) fix: log slashing offense names (AztecProtocol#23565) feat(p2p): tx validation cache (AztecProtocol#23585) chore: add KEDA deployment module (AztecProtocol#23553) chore: add KEDA prover agent autoscaling (AztecProtocol#23554) chore: update destroy_bootnode.sh (AztecProtocol#23626) chore: skip failing chonk_pinned_inputs.test in CI (AztecProtocol#23643) chore(ci): tolerate public authwit P2P receipt flake (AztecProtocol#23648) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slash attesters for attestations to invalid checkpoint proposals, mirroring invalid block proposal handling and preserving equivocation forgiveness.
Fix A-1074