Skip to content

fix: record zero-amount slashing offenses#23556

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-record-zero-amount-slashing-offenses
May 28, 2026
Merged

fix: record zero-amount slashing offenses#23556
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-record-zero-amount-slashing-offenses

Conversation

@alexghr

@alexghr alexghr commented May 26, 2026

Copy link
Copy Markdown
Contributor
  • record zero-amount slashing offenses instead of treating penalty 0 as disabled
  • keep slash vote signaling gated by existing summed vote output
  • upgrade stored duplicate offenses when a later observation has a higher amount

Fix A-1075

Stacked on top #23506

@spalladino spalladino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but why the change adding the slash amounts to offense keys?

Comment thread yarn-project/slasher/src/stores/offenses_store.test.ts Outdated
slashBroadcastedInvalidBlockPenalty > 0n ||
slashAttestInvalidCheckpointProposalPenalty > 0n ||
partOfCommittee ||
alwaysReexecuteBlockProposals ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should remove alwaysReexecuteBlockProposals from config altogether.

@alexghr alexghr force-pushed the ag/fix-slash-attestations-for-invalid-checkpoint-proposals branch from e9d865a to f285211 Compare May 26, 2026 16:21
@alexghr alexghr force-pushed the ag/fix-record-zero-amount-slashing-offenses branch 2 times, most recently from 3f79a1d to 5d342b5 Compare May 27, 2026 12:59
@alexghr alexghr force-pushed the ag/fix-slash-attestations-for-invalid-checkpoint-proposals branch from f285211 to 36b86e2 Compare May 27, 2026 12:59
Base automatically changed from ag/fix-slash-attestations-for-invalid-checkpoint-proposals to merge-train/spartan May 27, 2026 14:39
@alexghr alexghr force-pushed the ag/fix-record-zero-amount-slashing-offenses branch 2 times, most recently from bf66484 to d9c9314 Compare May 28, 2026 07:38
@alexghr alexghr force-pushed the ag/fix-record-zero-amount-slashing-offenses branch from d9c9314 to f1079ca Compare May 28, 2026 07:59
@alexghr alexghr enabled auto-merge (squash) May 28, 2026 08:01
@AztecBot

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/fe05ff1435f97139�fe05ff1435f971398;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "proposer invalidates multiple checkpoints" (498s) (code: 0) group:e2e-p2p-epoch-flakes

@alexghr alexghr merged commit fcd4ec2 into merge-train/spartan May 28, 2026
14 checks passed
@alexghr alexghr deleted the ag/fix-record-zero-amount-slashing-offenses branch May 28, 2026 08:34
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jun 4, 2026
BEGIN_COMMIT_OVERRIDE
fix(archiver): skip descendants of invalid-attestations checkpoints
(AztecProtocol#23502)
chore: scale network validators (AztecProtocol#23579)
fix(ci): nightly 10 TPS bench GCP auth and checkout (AztecProtocol#23586)
chore: set eth node resource profile (AztecProtocol#23583)
fix: wait for checkpoint before sentinel assertions (AztecProtocol#23573)
fix: slash attestations for invalid checkpoint proposals (AztecProtocol#23506)
test: fix web3signer pipelining
`e2e_multi_validator_node_key_store.test.ts` (AztecProtocol#23568)
fix: cap CI devbox hostname (AztecProtocol#23591)
test: stabilize invalid checkpoint descendant e2e (AztecProtocol#23582)
test(e2e): stabilize invalidation slots in `proposer invalidates
multiple checkpoints` (AztecProtocol#23590)
test(e2e): stabilize invalid proposal slashing target slot in
`attested_invalid_proposal` (AztecProtocol#23589)
chore(foundation): faster toBufferBE via zero fast-path (AztecProtocol#23592)
fix: honour BB_BINARY_PATH (AztecProtocol#23570)
chore: bump reth and lighthouse (AztecProtocol#23588)
chore: add web3signer and postgres node selectors (AztecProtocol#23598)
fix: do not symlink .codex folders (AztecProtocol#23593)
chore: fix claude and codex symlinking tests (AztecProtocol#23599)
test(e2e): narrow down sentinel check in `multiple_validators_sentinel`
(AztecProtocol#23604)
test(e2e): fix `proposer invalidates multiple checkpoints` timeout
(AztecProtocol#23608)
fix: record zero-amount slashing offenses (AztecProtocol#23556)
fix: log slashing offense names (AztecProtocol#23565)
feat(p2p): tx validation cache (AztecProtocol#23585)
chore: add KEDA deployment module (AztecProtocol#23553)
chore: add KEDA prover agent autoscaling (AztecProtocol#23554)
chore: update destroy_bootnode.sh (AztecProtocol#23626)
chore: skip failing chonk_pinned_inputs.test in CI (AztecProtocol#23643)
chore(ci): tolerate public authwit P2P receipt flake (AztecProtocol#23648)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants