Skip to content

test(e2e): stabilize invalidation slots in proposer invalidates multiple checkpoints#23590

Merged
spalladino merged 1 commit into
merge-train/spartanfrom
spl/stabilize-multiple-checkpoint-invalidation
May 27, 2026
Merged

test(e2e): stabilize invalidation slots in proposer invalidates multiple checkpoints#23590
spalladino merged 1 commit into
merge-train/spartanfrom
spl/stabilize-multiple-checkpoint-invalidation

Conversation

@spalladino

Copy link
Copy Markdown
Contributor

Summary:

  • Scan for consecutive bad checkpoint slots whose prior pipelined target slot is not owned by either intended bad proposer.
  • Keep the malicious-config injection tied to the selected bad proposers and remove the now-unnecessary non-null assertion.
  • Add an inline comment documenting why the prior pipelined target slot matters.

Why:
The test applies malicious checkpoint config while sequencers are already running. With proposer pipelining, the previous target slot can snapshot that config before the intended bad slots are built. If that prior proposer is one of the intended bad proposers, the test may spend the malicious config on the wrong checkpoint and stop validating the intended two-checkpoint invalidation path. This mirrors the slot-selection issue fixed for the invalid proposal slashing test, but applies it to the consecutive checkpoint invalidation scenario.

Testing:

  • yarn format end-to-end
  • yarn build
  • LOG_LEVEL="info; debug:sequencer,publisher,validator" yarn workspace @aztec/end-to-end test:e2e e2e_epochs/epochs_invalidate_block.parallel.test.ts -t "proposer invalidates multiple checkpoints"

@AztecBot

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/b7639f5b8e4d5e93�b7639f5b8e4d5e938;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "archiver skips a descendant of an invalid-attestations checkpoint" (397s) (code: 0) group:e2e-p2p-epoch-flakes

@spalladino spalladino changed the title test: stabilize multiple checkpoint invalidation slots test(e2e): stabilize invalidation slots in proposer invalidates multiple checkpoints May 27, 2026
@spalladino spalladino enabled auto-merge (squash) May 27, 2026 14:53
@spalladino spalladino merged commit 94a2f57 into merge-train/spartan May 27, 2026
17 checks passed
@spalladino spalladino deleted the spl/stabilize-multiple-checkpoint-invalidation branch May 27, 2026 15:34
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jun 4, 2026
BEGIN_COMMIT_OVERRIDE
fix(archiver): skip descendants of invalid-attestations checkpoints
(AztecProtocol#23502)
chore: scale network validators (AztecProtocol#23579)
fix(ci): nightly 10 TPS bench GCP auth and checkout (AztecProtocol#23586)
chore: set eth node resource profile (AztecProtocol#23583)
fix: wait for checkpoint before sentinel assertions (AztecProtocol#23573)
fix: slash attestations for invalid checkpoint proposals (AztecProtocol#23506)
test: fix web3signer pipelining
`e2e_multi_validator_node_key_store.test.ts` (AztecProtocol#23568)
fix: cap CI devbox hostname (AztecProtocol#23591)
test: stabilize invalid checkpoint descendant e2e (AztecProtocol#23582)
test(e2e): stabilize invalidation slots in `proposer invalidates
multiple checkpoints` (AztecProtocol#23590)
test(e2e): stabilize invalid proposal slashing target slot in
`attested_invalid_proposal` (AztecProtocol#23589)
chore(foundation): faster toBufferBE via zero fast-path (AztecProtocol#23592)
fix: honour BB_BINARY_PATH (AztecProtocol#23570)
chore: bump reth and lighthouse (AztecProtocol#23588)
chore: add web3signer and postgres node selectors (AztecProtocol#23598)
fix: do not symlink .codex folders (AztecProtocol#23593)
chore: fix claude and codex symlinking tests (AztecProtocol#23599)
test(e2e): narrow down sentinel check in `multiple_validators_sentinel`
(AztecProtocol#23604)
test(e2e): fix `proposer invalidates multiple checkpoints` timeout
(AztecProtocol#23608)
fix: record zero-amount slashing offenses (AztecProtocol#23556)
fix: log slashing offense names (AztecProtocol#23565)
feat(p2p): tx validation cache (AztecProtocol#23585)
chore: add KEDA deployment module (AztecProtocol#23553)
chore: add KEDA prover agent autoscaling (AztecProtocol#23554)
chore: update destroy_bootnode.sh (AztecProtocol#23626)
chore: skip failing chonk_pinned_inputs.test in CI (AztecProtocol#23643)
chore(ci): tolerate public authwit P2P receipt flake (AztecProtocol#23648)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants