fix(ci): bump avm_check_circuit per-test timeout to 120s for heavy txs#23771
Closed
AztecBot wants to merge 1 commit into
Closed
fix(ci): bump avm_check_circuit per-test timeout to 120s for heavy txs#23771AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
avm-check-circuitjob failed onnext(run 26762926745) with exit code124(timeout).The check runs
bb-avm avm_check_circuiton every dumped e2e AVM circuit input in parallel, each isolated withTIMEOUT=30sand the default 2 CPUs. 499 inputs passed; one timed out:Root cause
Not a constraint failure — a timeout. From the per-test log:
Simulating...→ app logic done (~2s)Generating trace...→ 23s (dominant cost, CPU-bound on the container's--cpus=2)Checking circuit... over 700560 rowsstarted, thentimeout: sending signal TERMat the 30s mark before it could finish.e2e_multiple_blobsproduces a much larger circuit (700560 rows) than the other e2e txs (which finish check-circuit in ~3s), so its trace generation + check exceeds the uniform 30s budget. TheTIMEOUT=30shas been unchanged since the feature was introduced (#18747), and the existing WARNING comment inavm_check_circuit_cmdsexplicitly anticipated this failure mode for larger txs.Fix
Raise the per-test timeout from
30sto120sinavm_check_circuit_cmds(yarn-project/end-to-end/bootstrap.sh). This gives ~2x headroom over the heaviest observed total (~23s trace + check) and room for future circuit growth. The change is zero-cost for the ~500 fast checks — they still exit in a few seconds, so neither parallelism nor stage wall-clock is affected — it only lets the heavy outlier finish instead of being killed mid-check. The WARNING comment is updated to reflect the heavy-tx case.No outer workflow/step timeout caps below this value, so the larger per-test budget takes effect.
Created by claudebox · group:
slackbot