fix(ci): bump avm_check_circuit per-test timeout to 120s for heavy txs#24030
Draft
AztecBot wants to merge 1 commit into
Draft
fix(ci): bump avm_check_circuit per-test timeout to 120s for heavy txs#24030AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
avm-check-circuitjob failed onnext(run 27367574268) with exit code124— a timeout, not a circuit correctness failure.The check runs
bb-avm avm_check_circuiton every dumped e2e AVM circuit input in parallel, each isolated withTIMEOUT=30sand the default 2 CPUs. Every other input passed in 4–8s; one timed out:Root cause
From the per-test log (
--cpus=2):This one
e2e_multiple_blobstx produces a ~700k-row circuit — far larger than the other e2e txs (which finish check-circuit in a few seconds), so its trace generation + check exceeds the uniform 30s budget and is killed mid-check. The triggering commit (#24026) is docs-only, so nothing in the circuit changed; the input is simply heavy enough to cross the boundary.TIMEOUT=30shas been unchanged since the feature landed in #18747, and the originalWARNINGcomment inavm_check_circuit_cmdsexplicitly anticipated this failure mode for larger txs.This is a recurrence: PR #23771 made the same fix on June 1 but was a draft that got closed unmerged on June 7, so
nextreverted to the 30s ceiling and the heavy tx times out again.Fix
Raise the per-test timeout from
30sto120sinavm_check_circuit_cmds(yarn-project/end-to-end/bootstrap.sh). This gives ~3–4x headroom over the heaviest observed total and room for future circuit growth.The change is zero-cost for the fast majority of checks — they still exit in a few seconds, so neither parallelism nor stage wall-clock is affected. Only the heavy outlier is allowed to run to completion instead of being killed mid-check. (Deliberately keeping the default 2 CPUs rather than bumping
CPUS, which would apply to all ~500 inputs and halve runner concurrency while barely speeding up the already-fast majority.)No outer workflow/step timeout caps below this value, so the larger per-test budget takes effect.
Created by claudebox · group:
slackbot