Skip to content

Key Vault: making crypto models congruent with .net's#8006

Merged
iscai-msft merged 3 commits into
Azure:masterfrom
iscai-msft:crypto_models_addition
Oct 18, 2019
Merged

Key Vault: making crypto models congruent with .net's#8006
iscai-msft merged 3 commits into
Azure:masterfrom
iscai-msft:crypto_models_addition

Conversation

@iscai-msft

Copy link
Copy Markdown
Contributor

No description provided.

@iscai-msft iscai-msft added KeyVault Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release labels Oct 17, 2019
@iscai-msft
iscai-msft requested a review from chlowell October 17, 2019 23:02
@iscai-msft
iscai-msft requested a review from schaabs as a code owner October 17, 2019 23:02
@iscai-msft iscai-msft self-assigned this Oct 17, 2019
@adxsdk6

adxsdk6 commented Oct 17, 2019

Copy link
Copy Markdown

Can one of the admins verify this patch?

@chlowell chlowell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me modulo some docstring updates 👍

Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_models.py Outdated
Comment thread sdk/keyvault/azure-keyvault-keys/tests/test_examples_crypto_async.py Outdated
@iscai-msft

Copy link
Copy Markdown
Contributor Author

/azp run python - keyvault - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft iscai-msft closed this Oct 18, 2019
@iscai-msft iscai-msft reopened this Oct 18, 2019
@iscai-msft
iscai-msft merged commit f519190 into Azure:master Oct 18, 2019
@iscai-msft
iscai-msft deleted the crypto_models_addition branch October 18, 2019 23:59
xiangyan99 added a commit that referenced this pull request Oct 19, 2019
* Update documentation link in CODEOWNERS (#8015)

* remove half of the extraneous ci.yml triggers on core

* logging policy with tests and bugfixes + conside impl (#8048)

* Key Vault: regenerated keyvault for paging logging (#8022)

* regenerated keyvault for paging logging

* fixed kwargs to pop max_page_size

* rename examples to samples (#8040)

* Key Vault: making crypto models congruent with .net's (#8006)

* shaped python's crypto classes to be congruent with .net's

* implemented Charles' comments and added changelog

* properly handling condition for job run (#8050)

* Fix typo allowed_header_namers in HttpLoggingPolicy (#8059)
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
* shaped python's crypto classes to be congruent with .net's

* implemented Charles' comments and added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants