Test and Skip condition should respect succeededOrFailed()#8050
Merged
Conversation
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
October 18, 2019 23:37
|
Can one of the admins verify this patch? |
mikeharder
approved these changes
Oct 18, 2019
xiangyan99
added a commit
that referenced
this pull request
Oct 19, 2019
* Update documentation link in CODEOWNERS (#8015) * remove half of the extraneous ci.yml triggers on core * logging policy with tests and bugfixes + conside impl (#8048) * Key Vault: regenerated keyvault for paging logging (#8022) * regenerated keyvault for paging logging * fixed kwargs to pop max_page_size * rename examples to samples (#8040) * Key Vault: making crypto models congruent with .net's (#8006) * shaped python's crypto classes to be congruent with .net's * implemented Charles' comments and added changelog * properly handling condition for job run (#8050) * Fix typo allowed_header_namers in HttpLoggingPolicy (#8059)
weshaggard
reviewed
Oct 21, 2019
|
|
||
| - job: 'Analyze' | ||
| condition: ne(variables['Skip.Analyze'], 'true') | ||
| condition: and(succeededOrFailed(), ne(variables['Skip.Analyze'], 'true')) |
Member
There was a problem hiding this comment.
Is this just to ensure it doesn't run when a build is canceled?
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.