Pull latest master#8063
Merged
Merged
Conversation
* regenerated keyvault for paging logging * fixed kwargs to pop max_page_size
* shaped python's crypto classes to be congruent with .net's * implemented Charles' comments and added changelog
xiangyan99
requested review from
bryevdv,
chlowell,
danieljurek,
iscai-msft,
mitchdenny,
scbedd,
schaabs and
weshaggard
as code owners
October 19, 2019 04:18
|
Can one of the admins verify this patch? |
Member
|
@xiangyan99 next time it would be good to rebase your changes on top of master so it is clear what your changes are. Looking at the commits and merge here it contains a number of commits that were already in master so it makes the diff and the history kind of noisy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.