refactor: more instance-generic async provisioning#1165
Merged
Conversation
comtalyst
force-pushed
the
comtalyst/nodeclaim-annotations-helper
branch
from
dd42341 to
9da82e9
Compare
comtalyst
force-pushed
the
comtalyst/refactor-cloudprovider-promise
branch
from
f5ff9ef to
6dc5332
Compare
comtalyst
added
the
size/L
comtalyst
force-pushed
the
comtalyst/nodeclaim-annotations-helper
branch
from
9da82e9 to
3bb55cd
Compare
…refactor-cloudprovider-promise
matthchr
reviewed
Oct 2, 2025
matthchr
previously approved these changes
Oct 7, 2025
Member
matthchr
left a comment
matthchr
left a comment
There was a problem hiding this comment.
Approved with some more nits
comtalyst
changed the base branch from
comtalyst/nodeclaim-annotations-helper
to
main
comtalyst
changed the base branch from
main
to
comtalyst/nodeclaim-annotations-helper
comtalyst
force-pushed
the
comtalyst/refactor-cloudprovider-promise
branch
from
c162c1b to
26c8415
Compare
Base automatically changed from
comtalyst/nodeclaim-annotations-helper
to
main
October 21, 2025 01:02
matthchr
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
In cloudprovider module, async provisioning handling logic unncessarily assume an instance is a VM instance. With the new instance kind coming up in Machine API integration, this refactor will lead to more code reusability between instances, as well as more clear layering regarding standalone NodeClaim handling.
How was this change tested?
Does this change impact docs?
Release Note