issues: close #081 after PR #1196 was closed#1220
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe outstanding-issues ledger adds a resolved/archive section and updates issue ChangesIssues ledger
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ng check (#1229) * docs(ledger): record prlanded outcomes for PRs #1204, #1215, #1220 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(prlanded): compare trees against the squash commit, not three-dot main Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Ledger-only correction.
#081was opened earlier today to warn that open PR #1196 would re-add the dual-listedAdmissionCommunityPtsaliases and partially undo #30. PR #1196 was closed at 15:22 UTC on 2026-07-25 as superseded by #913 / currentmain(~680 commits behind,CONFLICTING), and its successor #1198 does not touchsrc/lib/eval-document-matching.ts.The warning is therefore stale, and the underlying risk is now structurally guarded rather than merely watched: the generalized alias-disjointness and single-document contracts landed in PR #1215 fail closed if any later branch re-adds those aliases.
Change: move
#081from Open items to Resolved / archive with that outcome. One line removed, one line added; no other row, the queue, or theissues:next-idmarker is touched.#080(re-test the removed admission widening under an approved eval canary) stays open.RAG impact: no retrieval behaviour change — documentation ledger only.
Checks:
npm run format:changed,npm run docs:check-links(1182 references resolve),npm run verify:cheap(386 test files, 3421 tests passed).Summary by CodeRabbit
#081with its current resolution status and related safeguards.