Phone chrome: opaque header/footer, hide backdrops, and add paint/scroll tests#1246
Conversation
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMobile phone header and bottom-dock CSS now use updated opaque, transparent, and hidden-backdrop states. Composer breakpoint selection depends only on ChangesMobile chrome and composer behavior
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b18a09371
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #5823 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5f0591d71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/ui-phone-scroll.spec.ts`:
- Around line 160-163: Update the nearby comment in
tests/ui-phone-scroll.spec.ts to reflect that documents home uses "sm-up",
making heroOwnsPhoneComposer false on phones and causing the bottom dock and
backdrop to render; remove the outdated claim that the home state omits the
dock.
- Around line 184-190: Update the pillBackground assertion in the visible-state
checks to verify an alpha value of 0.92, rather than merely accepting any rgba
serialization. Preserve support for the existing color serialization formats
while ensuring regressions to other opacity values fail.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0b08044a-aad6-4fac-b062-eb500d03d6fb
📒 Files selected for processing (5)
src/app/globals.csssrc/components/ClinicalDashboard.tsxtests/mobile-chrome-paint-contract.test.tstests/mobile-composer-reserve.test.tstests/ui-phone-scroll.spec.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 2 unresolved review comments. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Head branch was pushed to by a user without write access
|
@codex. Please can you diagnose and fix the failing CI testing for me |
Summary
Testing
|
|
@codex please fix failing CI it keeps failing Here are logs 2026-07-26T01:36:23.7218439Z ##[group]Run npm run test:e2e:pr |
Summary
Testing
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a17f3e2fa6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BigSimmo
added
the
skip-branch-sync
…ter-behavior' into codex/pr1246-review-merge
…erge # Conflicts: # src/components/ClinicalDashboard.tsx
Motivation
Description
src/app/globals.cssto make.edge-glass-headerand.universal-headerrender as opaque (background: var(--surface)) under@media (max-width: 639px)and to hide.edge-glass-header-backdropelements on phones.var(--surface)background, hid.answer-footer-search-backdropon phones, and adjusted the.answer-footer-search-pillto use a less-translucentcolor-mix(in srgb, var(--surface) 92%, transparent)background to reduce compositing.tests/mobile-chrome-paint-contract.test.tsthat asserts the phone CSS contains the expected opaque header/footer and hidden backdrops.tests/ui-phone-scroll.spec.tswith a Playwright test that asserts the header is opaque, backdrops are hidden, the dock spans the full viewport width, the pill background is as expected, and that both header and dock release the viewport edges when hidden by scroll.Testing
tests/mobile-chrome-paint-contract.test.ts, and the assertions againstglobals.csspassed.tests/ui-phone-scroll.spec.ts, and the phone scroll/header/footer behavior assertions passed.Codex Task
Summary by CodeRabbit
Bug Fixes
Tests