fix(ui): restore edge-to-edge soft-glass phone footer#1264
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughChangesThe phone search dock now uses localized translucent glass backdrop rendering and opacity-based hiding. Calculator pages expose reserve-owner transition metadata, while shared scroll-hide calculations account for multiple reserves and a 96px collapse runway. CSS, unit, contract, and browser tests cover rendering and geometry behavior. Phone Chrome
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant PhonePage
participant SearchResultsLayout
participant MainContent
participant ScrollHideEngine
participant PhoneDock
PhonePage->>SearchResultsLayout: pass reserve transition state
SearchResultsLayout->>MainContent: render reserve data attributes
ScrollHideEngine->>MainContent: measure reserve owners and collapse runway
ScrollHideEngine->>PhoneDock: update hidden state
PhoneDock-->>PhonePage: animate opacity and backdrop visibility
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3ab24818
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/calculators/search-page.tsx`:
- Around line 666-683: Clear dockFocused asynchronously when the mobile search
dock unmounts, covering the submitSearch → setOpenId path where onBlurCapture
may not fire. Add an unmount cleanup near the dock focus state/effect in
search-page.tsx that resets dockFocused without synchronously updating state
during teardown, preserving dockHidden, reserveTransitioning, and reserve
release behavior; follow the teardown pattern documented in
master-search-header.tsx.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f8f67d5-9adb-4c17-8ba8-91b8ebc0894b
📒 Files selected for processing (11)
docs/branch-review-ledger.mddocs/search-chrome-behaviour.mdsrc/app/globals.csssrc/components/DocumentViewer.tsxsrc/components/calculators/search-page.tsxsrc/components/clinical-dashboard/master-search-header.tsxsrc/components/clinical-dashboard/search-results-layout.tsxsrc/components/clinical-dashboard/use-hide-on-scroll.tstests/mobile-chrome-paint-contract.test.tstests/ui-phone-scroll.spec.tstests/use-hide-on-scroll.test.ts
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #5893 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
1 participant
Summary
Verification
npm run verify:pr-local— PASS (format, lint, typecheck, 393 unit files / 3517 passed / 2 skipped, production build/client scan)npm run verify:ui— isolated production build; 312/313 Chromium passed, sole unchanged Answer short-runway geometry outlier passed immediate exact rerun 1/1npm run verify:release— not run; no release/provider-backed gate needed for this CSS/browser-scoped PRRisk and rollout
RAG impact: no retrieval behaviour change — phone chrome CSS, layout geometry, documentation, and browser tests only
Clinical Governance Preflight
Not applicable: no ingestion, answer generation, search/ranking, source rendering, document access, privacy, production environment, or clinical output change.
Notes
Summary by CodeRabbit
New Features
Bug Fixes
Tests