Skip to content

fix(ui): eliminate phone footer safe-area strip#1265

Merged
BigSimmo merged 2 commits into
mainfrom
codex/phone-footer-paint
Jul 26, 2026
Merged

fix(ui): eliminate phone footer safe-area strip#1265
BigSimmo merged 2 commits into
mainfrom
codex/phone-footer-paint

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fade the shared phone footer scrim and every blur mask to true transparency at the physical bottom edge.
  • Reduce the normal glass tint and pill opacity so page content remains visible around the composer.
  • Retire the WebKit backdrop layer after the existing 240 ms hide transition, with an immediate reduced-motion path.
  • Strengthen Therapy and shared-dock tests so high-alpha fallbacks, opaque terminal stops, or retained hidden paint cannot pass again.

Verification

  • npm run verify:pr-local
  • npm run verify:ui
  • Focused Therapy production test in Chromium and WebKit
  • Focused shared Calculators dock production test in Chromium and WebKit

Verification not run: npm run verify:release; risk-scoped coverage used the complete 314-test Chromium production UI suite plus focused WebKit safe-area/compositor cases. No live OpenAI, Supabase, Railway, or deployment check was run.

Risk and rollout

  • Risk: Low-to-moderate presentation risk. The shared phone dock changes across submitted/result modes; the principal residual risk is physical iOS momentum/compositor behavior beyond local WebKit emulation.
  • Rollback: Revert this PR's squash commit to restore the prior footer paint and tests.
  • Provider or production effects: GitHub PR and merge are explicitly authorized. Merging main will trigger the repository's normal Railway auto-deploy; no direct Railway mutation is performed here.

Clinical Governance Preflight

Not applicable: presentation-only CSS, browser tests, and documentation. No ingestion, answer generation, retrieval/ranking, source rendering, document access, privacy, environment, or clinical-output behavior changes.

Notes

RAG impact: no retrieval behaviour change — CSS, browser/static test coverage, and search-chrome documentation only.

Summary by CodeRabbit

  • Bug Fixes

    • Improved the mobile search footer’s edge-to-edge rendering with transparent physical-edge transitions.
    • Refined backdrop blur, tinting, masking, and pill transparency for a more natural glass effect.
    • Ensured the footer backdrop fully fades and becomes hidden after scrolling, including reduced-motion behavior.
  • Documentation

    • Updated mobile search dock behavior and release-readiness records.
  • Tests

    • Expanded coverage for translucent rendering, transparent mask terminals, and hidden-state behavior.

@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The mobile search footer backdrop now uses transparent terminal rendering, revised blur and tint masks, and delayed visibility hiding. CSS contract and UI tests verify the updated paint, opacity, visibility, reduced-motion, and scroll-hidden behavior.

Changes

Phone footer paint behavior

Layer / File(s) Summary
Backdrop paint and transparency
docs/search-chrome-behaviour.md, src/app/globals.css
Updates backdrop gradients, blur masks, fallback tinting, pill opacity, and the physical-edge transparency invariant.
Hidden-state transitions
src/app/globals.css
Adds delayed visibility: hidden handling for the scroll-hidden backdrop and immediate hiding for mobile reduced-motion mode.
Paint and scroll validation
tests/mobile-chrome-paint-contract.test.ts, tests/ui-phone-scroll.spec.ts, docs/branch-review-ledger.md
Verifies terminal transparency, bounded alpha, pill opacity, hidden backdrop state, and records the release-readiness review.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: codex

Suggested reviewers: cursoragent, claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main UI fix: removing the phone footer safe-area strip.
Description check ✅ Passed The PR description follows the template well, with Summary, Verification, Risk and rollout, Clinical Governance Preflight, and Notes all addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/phone-footer-paint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 1108: Correct the date in the ledger entry for commit
e1657a4a4e3e25b4a35a1dcf544b3efddb123c3f to the actual review date, July 26,
2026, or defer adding the entry until July 27 after the review occurs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cdf0ceb4-b79c-485e-9134-feffcd93549c

📥 Commits

Reviewing files that changed from the base of the PR and between 2b08c9b and 2aba74b.

📒 Files selected for processing (5)
  • docs/branch-review-ledger.md
  • docs/search-chrome-behaviour.md
  • src/app/globals.css
  • tests/mobile-chrome-paint-contract.test.ts
  • tests/ui-phone-scroll.spec.ts

Comment thread docs/branch-review-ledger.md
@BigSimmo
BigSimmo merged commit cc1abfe into main Jul 26, 2026
39 checks passed
@BigSimmo
BigSimmo deleted the codex/phone-footer-paint branch July 26, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant