fix: unify answer recovery states with shared EmptyState

[BigSimmo]

Summary

• Unify answer recovery empty/error states onto the shared EmptyState primitive for consistent clinical journey messaging.
• Recreates closed fix: unify answer recovery states #776 / original Unify answer recovery states with shared EmptyState primitive #755 with PR-policy-compliant metadata.

Verification

• Hosted Static PR checks / Build / Unit coverage / Advisory UI on predecessor heads.
• npm run verify:ui evidence via hosted UI gates on predecessor heads.
• UI verification not run locally in this babysit pass: relying on hosted Production UI.

Risk and rollout

• Risk: low; presentation-only recovery state unification with no retrieval contract change.
• Rollback: revert this PR to restore prior inline recovery markup.
• Provider or production effects: None

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

  

Summary by CodeRabbit

• New Features

  • Improved answer recovery screens with clearer empty-state messaging for cancelled requests, no results, and errors.
  • Added contextual actions such as retrying, focusing the question field, and searching documents.
  • Added visual tones for neutral, informational, and error states.

• Accessibility

  • Improved status and alert announcements so important recovery messages are communicated more effectively.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

📝 Walkthrough

Walkthrough

EmptyState now supports recovery actions, live-region semantics, tone styling, and test IDs. ClinicalDashboard uses it for cancelled, no-results, and error answer states, with tests covering status and alert roles.

Changes

Answer recovery UI

Layer / File(s)	Summary
Extend EmptyState contract src/components/ui-primitives.tsx, tests/ui-primitives.dom.test.tsx	EmptyState supports actions, live-region roles, neutral/info/danger tones, test IDs, and tests for status and alert rendering.
Integrate answer recovery states src/components/ClinicalDashboard.tsx	Cancelled, no-results, and generic error states render configured EmptyState variants while retaining retry, rephrase, and document-search callbacks.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• BigSimmo/Database#798: Directly overlaps the ClinicalDashboard EmptyState integration and shared component API changes.

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: consolidating answer recovery states into the shared EmptyState component.
Description check	✅ Passed	The description covers summary, verification, risk/rollback, and governance preflight; only minor template details like Notes are missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/unify-answer-recovery-db17

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/ClinicalDashboard.tsx`:
- Around line 3648-3655: Update the error EmptyState branch in ClinicalDashboard
to distinguish errors by activeModeResultKind instead of always presenting
“Answer unavailable.” Use the appropriate title and icon for document-search and
clipboard errors, while preserving the answer-specific presentation for answer
errors.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc1fddb3-1808-42b7-802d-9563fea5fb17

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff8095 and d7afb2f.

📒 Files selected for processing (3)

• src/components/ClinicalDashboard.tsx
• src/components/ui-primitives.tsx
• tests/ui-primitives.dom.test.tsx

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not label every dashboard error as an answer failure.

This branch also handles document-search and clipboard errors, so those modes now display “Answer unavailable.” Select the title/icon based on activeModeResultKind, or restrict this EmptyState to answer errors.

Proposed fix

-                    title="Answer unavailable"
+                    title={activeModeResultKind === "answer" ? "Answer unavailable" : "Search unavailable"}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	) : error ? (
	<EmptyState
	icon={CircleAlert}
	title="Answer unavailable"
	body={error}
	live="assertive"
	tone="danger"
	testId="answer-error"
	) : error ? (
	<EmptyState
	icon={CircleAlert}
	title={activeModeResultKind === "answer" ? "Answer unavailable" : "Search unavailable"}
	body={error}
	live="assertive"
	tone="danger"
	testId="answer-error"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/ClinicalDashboard.tsx` around lines 3648 - 3655, Update the
error EmptyState branch in ClinicalDashboard to distinguish errors by
activeModeResultKind instead of always presenting “Answer unavailable.” Use the
appropriate title and icon for document-search and clipboard errors, while
preserving the answer-specific presentation for answer errors.