Skip to content

fix: refine answer recovery message and match scope#833

Open
BigSimmo wants to merge 3 commits into
mainfrom
codex/clinical-journey-recovery-pr-final-merge
Open

fix: refine answer recovery message and match scope#833
BigSimmo wants to merge 3 commits into
mainfrom
codex/clinical-journey-recovery-pr-final-merge

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Force a consistent recovery-state title to Answer unavailable across answer and search paths.
  • Scope showUniversalAlsoMatches rendering by activeModeResultKind so answer/search modes render matching content without ambiguity.
  • Preserve existing recovery actions, source contracts, and ARIA behavior; no clinical data/model/routing logic changed.

Verification

  • npx vitest run tests/ui-primitives.dom.test.tsx --reporter=dot (passed in original working tree).
  • npx prettier --check src/components/ClinicalDashboard.tsx (passed).
  • npm run test:focused -- --files src/components/ClinicalDashboard.tsx (ran successfully for focused harness; no matching tests in this path).
  • npm run verify:cheap (failed in this state due missing esbuild dependency, unrelated to this patch).

Summary by CodeRabbit

  • Bug Fixes
    • Standardized the main error message to display “Answer unavailable” when results cannot be provided.
    • Improved result-state handling so related search matches appear correctly across answer and non-answer views.
    • Refined error and result presentation for a more consistent experience when switching between clinical dashboard modes.

@supabase

supabase Bot commented Jul 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bd6af0ea-2d10-476c-8679-bd710158d103

📥 Commits

Reviewing files that changed from the base of the PR and between b45f095 and 7b1028c.

📒 Files selected for processing (1)
  • src/components/ClinicalDashboard.tsx

📝 Walkthrough

Walkthrough

ClinicalDashboard now always labels the main error state “Answer unavailable” and separates UniversalSearchAlsoMatches rendering for answer versus non-answer result modes.

Changes

Clinical dashboard rendering

Layer / File(s) Summary
Mode-aware error and match rendering
src/components/ClinicalDashboard.tsx
The main error state uses a fixed “Answer unavailable” title, while universal search matches render through explicit answer and non-answer mode conditions.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: consistent recovery messaging and scoped match rendering.
Description check ✅ Passed Summary and verification are provided, but Risk/Rollback, Clinical Governance Preflight, and Notes sections are missing.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/clinical-journey-recovery-pr-final-merge

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant