Conversation
Correcting action error.
testing removing the error on branch argument
Switched the path to only the /partitura/partitura
…match file import with minor complexity addition.
update note feature extraction for dynamic features
Addresses Issue 278
addressed issue #275
previous epsilon was flushed to zero, so the final duration was zero, leading to nan tempos.
gracefully deal with final notes that happen to be grace notes in `get_unique_seq`
…ning), inlcuded test by duplicating line on match file.
Add method for MatchFile validation
`compute_matched_score` returns all basic performance features (bp, timing, articulation, velocity) `make_note_features` with `force_fixed_size = True` skips metrical features for consistent shape.
`compute_matched_score` returns all basic performance features (bp, timing, articulation, velocity) `make_note_features` with `force_fixed_size = True` skips metrical and time signature features for consistent array shape.
This pull request extends the default values for feature normalization
manoskary
previously approved these changes
Jul 5, 2023
Member
manoskary
left a comment
manoskary
left a comment
There was a problem hiding this comment.
This PR addresses Validation of Match Files, some normalization utilities, and minor bug fixes. A lot of files are edited because the blacken pipeline has been updated and applied on the develop branch.
fix versioning for sphinx and documentation compilation.
manoskary
previously approved these changes
Jul 5, 2023
CarlosCancino-Chacon
approved these changes
Jul 5, 2023
Member
CarlosCancino-Chacon
left a comment
CarlosCancino-Chacon
left a comment
There was a problem hiding this comment.
The pull request looks quite ok, but it took a little bit longer to sort out through all of the changes due to blacken (I hope I did not miss anything 😉).
There are two really minor comments (about a potential optimization of a couple of lines), which can be safely ignored.
CarlosCancino-Chacon
previously approved these changes
Jul 5, 2023
sildater
dismissed stale reviews from CarlosCancino-Chacon and manoskary
via
36450da
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 85.33% 85.36% +0.03%
==========================================
Files 79 79
Lines 13561 13590 +29
==========================================
+ Hits 11572 11601 +29
Misses 1989 1989
☔ View full report in Codecov by Sentry. |
CarlosCancino-Chacon
approved these changes
Jul 5, 2023
manoskary
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.1
Targeted release date: 2023-07-05
New Features
Bug Fixes
to_matched_score- forcing note order is not working properly. #277feature_function_activation#272Other Changes